Page MenuHomeFreeBSD

sleep: Overhaul.
ClosedPublic

Authored by des on Mar 22 2024, 9:50 AM.
Tags
None
Referenced Files
F167976871: D44471.id136188.diff
Tue, Aug 25, 5:32 PM
F167962014: D44471.id136186.diff
Tue, Aug 25, 3:43 PM
F167948300: D44471.id136187.diff
Tue, Aug 25, 2:08 PM
F167947826: D44471.id136195.diff
Tue, Aug 25, 2:04 PM
F167946542: D44471.id136188.diff
Tue, Aug 25, 1:53 PM
F167897990: D44471.id.diff
Tue, Aug 25, 8:05 AM
Unknown Object (File)
Mon, Aug 24, 8:42 PM
Unknown Object (File)
Mon, Aug 24, 7:44 PM
Subscribers

Details

Reviewers
se
kevans
Group Reviewers
Klara
manpages
Commits
rG2295cae7e606: sleep: Overhaul.
Summary

Program:

  • Add a dummy getopt(3) loop to handle --.
  • Move interval parsing out into a separate function.
  • Print a diagnostic for every invalid interval.
  • Check for NaN and infinity.
  • Improve bounds checks.

Manual page:

  • Miscellaneous markup fixes.
  • Reword DESCRIPTION section.
  • Move text about GNU compatibility to STANDARDS section.
  • Convert examples from csh to sh.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56773
Build 53661: arc lint + arc unit

Event Timeline

des requested review of this revision.Mar 22 2024, 9:50 AM

add <unistd.h> for getopt()

bcr added a subscriber: bcr.

OK from manpages.

just remembered that we need to test for equality after casting

print tv_sec as long rather than int

smallest value representable by struct timespec

This revision is now accepted and ready to land.Mar 25 2024, 3:33 PM

remove obsolete comment, use exit instead of return

This revision now requires review to proceed.Mar 25 2024, 3:40 PM
This revision is now accepted and ready to land.Mar 25 2024, 3:41 PM
This revision was automatically updated to reflect the committed changes.