Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches
ClosedPublic
Actions

Authored by vvd on Mar 5 2024, 12:14 PM.

Details

Reviewers

arrowd
tcberner
adamw

Group Reviewers

portmgr

Commits

R11:cab93d2304d3: Mk/bsd.options.mk: add possibility set default options for other (not defined…

Summary

Examples on real ports:

graphics/khronos-texture

Without this feature:

OPTIONS_DEFAULT_aarch64=        NEON
OPTIONS_DEFAULT_amd64=          SSE2
OPTIONS_DEFAULT_armv6=          NONE
OPTIONS_DEFAULT_armv7=          NEON
OPTIONS_DEFAULT_i386=           NONE
OPTIONS_DEFAULT_mips=           NONE
OPTIONS_DEFAULT_mips64=         NONE
OPTIONS_DEFAULT_powerpc=        NONE
OPTIONS_DEFAULT_powerpc64=      NONE
OPTIONS_DEFAULT_powerpc64le=    NONE
OPTIONS_DEFAULT_powerpcspe=     NONE
OPTIONS_DEFAULT_riscv64=        NONE
OPTIONS_DEFAULT_riscv64sf=      NONE

With this feature:

OPTIONS_DEFAULT_aarch64=        NEON
OPTIONS_DEFAULT_amd64=          SSE2
OPTIONS_DEFAULT_armv7=          NEON
OPTIONS_DEFAULT_OTHER_ARCHS=   NONE

sysutils/nut{,-devel} (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277089)

Without:

OPTIONS_DEFAULT_amd64=  FREEIPMI
OPTIONS_DEFAULT_i386=   FREEIPMI
OPTIONS_DEFAULT_powerpc=        FREEIPMI
OPTIONS_DEFAULT_powerpc64=      FREEIPMI
OPTIONS_DEFAULT_powerpc64le=    FREEIPMI
OPTIONS_DEFAULT_riscv64=        FREEIPMI
OPTIONS_DEFAULT_riscv64sf=      FREEIPMI

With:

OPTIONS_DEFAULT_aarch64=
OPTIONS_DEFAULT_armv6=
OPTIONS_DEFAULT_armv7=
OPTIONS_DEFAULT_OTHER_ARCHS=   FREEIPMI

Tested with make -V OPTIONS_DEFAULT and build in poudriere.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vvd requested review of this revision.Mar 5 2024, 12:14 PM

vvd created this revision.

The new var should be names OPTIONS_DEFAULT_OTHER_ARCHS, without "E", to follow ONLY_FOR_ARCHS.

vvd updated this revision to Diff 135414.Mar 5 2024, 4:45 PM

vvd edited the summary of this revision. (Show Details)

ping

mat added a subscriber: mat.Mar 16 2024, 5:50 PM

mat added inline comments.

Mk/bsd.options.mk
222	We use `.if defined(x)` in the ports tree, not `.ifdef x`

vvd updated this revision to Diff 135831.Mar 16 2024, 7:21 PM

vvd marked an inline comment as done.

vvd added inline comments.

Mk/bsd.options.mk
222	Done.

ping again

The full list of arches is here: https://www.freebsd.org/platforms/

OPTIONS_DEFAULT_armv6=          NONE
OPTIONS_DEFAULT_i386=           NONE
OPTIONS_DEFAULT_mips=           NONE
OPTIONS_DEFAULT_mipsel=         NONE
OPTIONS_DEFAULT_mipselhf=       NONE
OPTIONS_DEFAULT_mipshf=         NONE
OPTIONS_DEFAULT_mipsn32=        NONE
OPTIONS_DEFAULT_mips64=         NONE
OPTIONS_DEFAULT_mips64el=       NONE
OPTIONS_DEFAULT_mips64elhf=     NONE
OPTIONS_DEFAULT_mips64hf=       NONE
OPTIONS_DEFAULT_powerpc=        NONE
OPTIONS_DEFAULT_powerpc64=      NONE
OPTIONS_DEFAULT_powerpc64le=    NONE
OPTIONS_DEFAULT_powerpcspe=     NONE
OPTIONS_DEFAULT_riscv64=        NONE
OPTIONS_DEFAULT_riscv64sf=      NONE

Instead of one line: