Paths

Table of Contentst

Differential D44288

unionfs: implement VOP_UNP_* and remove special VSOCK vnode handling
ClosedPublic
Actions

Authored by jah on Mar 10 2024, 2:09 AM.

Tags

None

Referenced Files

	F102715784: D44288.id.diff
	Sat, Nov 16, 6:44 AM

	Unknown Object (File)
	Thu, Nov 14, 3:23 AM

	Unknown Object (File)
	Mon, Nov 11, 5:16 PM

	Unknown Object (File)
	Mon, Nov 11, 10:17 AM

	Unknown Object (File)
	Mon, Oct 21, 5:30 AM

	Unknown Object (File)
	Mon, Oct 21, 5:30 AM

	Unknown Object (File)
	Sat, Oct 19, 12:57 AM

	Unknown Object (File)
	Sat, Oct 19, 12:56 AM

View All 57 Files

Subscribers

Details

Reviewers

glebius
kib
markj
olce

Commits

rG7b86d14bfccb: unionfs: implement VOP_UNP_* and remove special VSOCK vnode handling
rGeee6217b40df: unionfs: implement VOP_UNP_* and remove special VSOCK vnode handling

Summary

unionfs has a bunch of clunky special-case code to avoid creating
unionfs wrapper vnodes for AF_UNIX sockets. This was added in 2008
to address PR 118346, but in the intervening years the VOP_UNP_*
operations have been added to provide a clean interface to allow
sockets to work in the presence of stacked filesystems.

PR: 275871
Tested by: Karlo Miličević <karlo98.m@gmail.com>
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56644
Build 53532: arc lint + arc unit

Event Timeline

jah created this revision.Mar 10 2024, 2:09 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 10 2024, 2:09 AM

jah requested review of this revision.Mar 10 2024, 2:09 AM

Harbormaster completed remote builds in B56524: Diff 135574.Mar 10 2024, 2:10 AM

agh_riseup.net added a subscriber: agh_riseup.net.Mar 10 2024, 1:32 PM

kib accepted this revision.Mar 10 2024, 5:32 PM

This revision is now accepted and ready to land.Mar 10 2024, 5:32 PM

Great! More cruft removed, including one call to unionfs_relookup(). I have a few suggestions.

sys/fs/unionfs/union_vnops.c
1044–1046	I would now assert that `a_vp` is also a unionfs node.
1068–1069	`unp` is never supposed to be NULL now here.
1071–1072	Same here.

Code review feedback, also remove a nonsensical check from unionfs_link()

This revision now requires review to proceed.Mar 16 2024, 3:49 PM

Harbormaster completed remote builds in B56644: Diff 135823.Mar 16 2024, 3:49 PM

olce accepted this revision.Mar 20 2024, 4:02 AM

This revision is now accepted and ready to land.Mar 20 2024, 4:02 AM

Closed by commit rGeee6217b40df: unionfs: implement VOP_UNP_* and remove special VSOCK vnode handling (authored by jah). · Explain WhyMar 24 2024, 2:12 AM

This revision was automatically updated to reflect the committed changes.

jah added a commit: rGeee6217b40df: unionfs: implement VOP_UNP_* and remove special VSOCK vnode handling.

jah added a commit: rG7b86d14bfccb: unionfs: implement VOP_UNP_* and remove special VSOCK vnode handling.Apr 7 2024, 12:32 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

unionfs/

173 lines

Diff 135823

sys/fs/unionfs/union_vnops.c

Loading...