Page MenuHomeFreeBSD
Differential D43602

nvme: Use the NVMEM macro instead of expanded versions
ClosedPublic
Actions

Authored by jhb on Jan 25 2024, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 10 2025, 3:53 AM
Unknown Object (File)
Feb 10 2025, 3:53 AM
Unknown Object (File)
Feb 10 2025, 3:53 AM
Unknown Object (File)
Jan 27 2025, 2:58 PM
Unknown Object (File)
Jan 24 2025, 5:06 PM
Unknown Object (File)
Jan 23 2025, 6:47 PM
Unknown Object (File)
Jan 22 2025, 2:53 AM
Unknown Object (File)
Jan 11 2025, 6:57 PM
View All 46 Files
Subscribers
dab

Details

Reviewers
imp
chuck
Commits
rG2208f2c15688: nvme: Use the NVMEM macro instead of expanded versions
rG8488fc417fc2: nvme: Use the NVMEM macro instead of expanded versions
Summary

A few of these omitted a shift of 0, but this is more consistent.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
6 lines
2 lines

Diff 133521

View Options

sys/dev/nvme/nvme_ctrlr.c

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Linespublic:
/* Default constructor: an Invalid guid */ /* Default constructor: an Invalid guid */
Guid(); Guid();
/* Construct a guid from a provided integer */ /* Construct a guid from a provided integer */
Guid(uint64_t guid); Guid(uint64_t guid);
/* Construct a guid from a string in base 8, 10, or 16 */ /* Construct a guid from a string in base 8, 10, or 16 */
Guid(const std::string &guid); Guid(const std::string &guid);
static Guid InvalidGuid(); static Guid InvalidGuid();
/* Assignment */
Guid& operator=(const Guid& rhs);
/* Test the validity of this guid. */ /* Test the validity of this guid. */
bool IsValid() const; bool IsValid() const;
/* Comparison to other Guid operators */ /* Comparison to other Guid operators */
bool operator==(const Guid& rhs) const; bool operator==(const Guid& rhs) const;
bool operator!=(const Guid& rhs) const; bool operator!=(const Guid& rhs) const;
/* Integer conversion operators */ /* Integer conversion operators */
Show All 19 LinesGuid::Guid(uint64_t guid)
: m_GUID(guid) : m_GUID(guid)
{ {
} }
inline Guid inline Guid
Guid::InvalidGuid() Guid::InvalidGuid()
{ {
return (Guid(INVALID_GUID)); return (Guid(INVALID_GUID));
}
inline Guid&
Guid::operator=(const Guid &rhs)
{
m_GUID = rhs.m_GUID;
return (*this);
} }
inline bool inline bool
Guid::IsValid() const Guid::IsValid() const
{ {
return (m_GUID != INVALID_GUID); return (m_GUID != INVALID_GUID);
} }
Show All 29 Lines
View Options

sys/dev/nvme/nvme_ns.c

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Linespublic:
/* Default constructor: an Invalid guid */ /* Default constructor: an Invalid guid */
Guid(); Guid();
/* Construct a guid from a provided integer */ /* Construct a guid from a provided integer */
Guid(uint64_t guid); Guid(uint64_t guid);
/* Construct a guid from a string in base 8, 10, or 16 */ /* Construct a guid from a string in base 8, 10, or 16 */
Guid(const std::string &guid); Guid(const std::string &guid);
static Guid InvalidGuid(); static Guid InvalidGuid();
/* Assignment */
Guid& operator=(const Guid& rhs);
/* Test the validity of this guid. */ /* Test the validity of this guid. */
bool IsValid() const; bool IsValid() const;
/* Comparison to other Guid operators */ /* Comparison to other Guid operators */
bool operator==(const Guid& rhs) const; bool operator==(const Guid& rhs) const;
bool operator!=(const Guid& rhs) const; bool operator!=(const Guid& rhs) const;
/* Integer conversion operators */ /* Integer conversion operators */
Show All 19 LinesGuid::Guid(uint64_t guid)
: m_GUID(guid) : m_GUID(guid)
{ {
} }
inline Guid inline Guid
Guid::InvalidGuid() Guid::InvalidGuid()
{ {
return (Guid(INVALID_GUID)); return (Guid(INVALID_GUID));
}
inline Guid&
Guid::operator=(const Guid &rhs)
{
m_GUID = rhs.m_GUID;
return (*this);
} }
inline bool inline bool
Guid::IsValid() const Guid::IsValid() const
{ {
return (m_GUID != INVALID_GUID); return (m_GUID != INVALID_GUID);
} }
Show All 29 Lines