Page MenuHomeFreeBSD
Differential D43529

Add kern_openatfp(9)
ClosedPublic
Actions

Authored by kib on Jan 20 2024, 8:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 21, 11:06 AM
Unknown Object (File)
Mon, Oct 21, 11:06 AM
Unknown Object (File)
Oct 7 2024, 12:24 AM
Unknown Object (File)
Sep 24 2024, 10:07 AM
Unknown Object (File)
Sep 13 2024, 8:50 PM
Unknown Object (File)
Sep 12 2024, 6:16 PM
Unknown Object (File)
Sep 12 2024, 6:16 PM
Unknown Object (File)
Sep 12 2024, 6:16 PM
View All 43 Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
markj
pjd
Commits
rGc662306e19ce: Add kern_openatfp(9)
rG2a284076ecb4: kern_openat(): rename fd argument to dirfd
rG3d59b93b207e: kern_openat(): minor style fixes
Summary

See https://github.com/openzfs/zfs/pull/15630

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jan 20 2024, 8:39 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 20 2024, 8:39 PM
kib requested review of this revision.Jan 20 2024, 8:39 PM
pjd requested changes to this revision.Jan 20 2024, 9:59 PM

Thank you for working on this!

sys/kern/vfs_syscalls.c
1234

Personally I'd just add 'return (0)' here and eliminate 'else' below, which would reduce the diff.

I also don't see '*fpp = fp' anywhere.

This revision now requires changes to proceed.Jan 20 2024, 9:59 PM
kib updated this revision to Diff 133105.Jan 20 2024, 10:14 PM
kib marked an inline comment as done.

Do assign *fpp.

Herald added subscribers: glebius, melifaro, ae. · View Herald TranscriptJan 20 2024, 10:14 PM
kib updated this revision to Diff 133106.Jan 20 2024, 10:15 PM

Fix diff generation.

pjd accepted this revision.Jan 20 2024, 10:21 PM
This revision is now accepted and ready to land.Jan 20 2024, 10:21 PM
markj added inline comments.Jan 22 2024, 2:51 PM
sys/kern/vfs_syscalls.c
1116
1275

Is there a specific scenario you are guarding against here?

kib marked 2 inline comments as done.Jan 22 2024, 10:00 PM
kib added inline comments.
sys/kern/vfs_syscalls.c
1275

Recursing into VFS, which we sort of explicitly enable there with a backdoor into filesystem driver VOP_CREATE/VOP_OPEN.

It is similar how td_fpop is handled for devfs, to avoid unlikely but hard to diagnose surprises.

markj accepted this revision.Jan 23 2024, 2:33 PM
Closed by commit rG3d59b93b207e: kern_openat(): minor style fixes (authored by kib). · Explain WhyJan 24 2024, 5:13 AM
This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.
kib added a commit: rG3d59b93b207e: kern_openat(): minor style fixes.
kib added a commit: rG2a284076ecb4: kern_openat(): rename fd argument to dirfd.
kib added a commit: rGc662306e19ce: Add kern_openatfp(9).
GitHub <noreply@github.com> mentioned this in rGa4bf6baaeb70: Fix file descriptor leak on pool import..Jan 24 2024, 11:39 AM
Brian Behlendorf <behlendorf1@llnl.gov> mentioned this in rG3425484eb907: Fix file descriptor leak on pool import..Feb 23 2024, 10:40 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
6 lines

Diff 133252

View Options

sys/kern/vfs_syscalls.c

Loading...