Page MenuHomeFreeBSD

Revert "linuxkpi: `GFP_KERNEL` equals `M_NOWAIT` now"
ClosedPublic

Authored by dumbbell on Dec 7 2023, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 12:14 AM
Unknown Object (File)
Sun, Jun 16, 9:27 PM
Unknown Object (File)
Sat, Jun 15, 2:30 AM
Unknown Object (File)
Mon, May 27, 8:06 AM
Unknown Object (File)
May 12 2024, 12:46 PM
Unknown Object (File)
Apr 27 2024, 5:07 PM
Unknown Object (File)
Apr 27 2024, 7:51 AM
Unknown Object (File)
Jan 23 2024, 10:17 AM

Details

Summary

This change seems to break some drivers such as the mlx5*(4) drivers.

As kib@ says:

According to the 'official' Linux kernel documentation, the GFP_KERNEL
flag implies sleepable context.

It was introduced while working on the new vt(4)/DRM integration. During this work, doing sleepable allocations broke vt(4) and the DRM drivers. However, I made further improvements and some locking-related fixed to the new integration without revisiting the need for it.

After more testing, the improvements to the integration mentionned above seems to make the change to GFP_KERNEL unneeded now. I can thus revert it to restore expectations of other drivers.

This reverts commit D42054.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I did it locally for Nvidia to keep stuff running.

This revision is now accepted and ready to land.Dec 7 2023, 7:40 PM