I think it'd be a good idea to add these as an include - that way, it's easier to enable or disable on a case-by-case basis.

In D42961#979425, @debdrup wrote:

I think it'd be a good idea to add these as an include - that way, it's easier to enable or disable on a case-by-case basis.

What do you mean by "as an include"?

With ZFS now widely used and the default install doing compression, we no longer have to compress log files to save space.

There're still people making UFS/UFS2 as the root partition. I think the above conclusion is aggressive.
CC @delphij

This is a quality-of-life fix, mainly. to make it easier to search all logs with the same command. e.g. you don't have to use bzgrep.

For searching logs, agreed.

In D42961#982172, @zlei wrote:

With ZFS now widely used and the default install doing compression, we no longer have to compress log files to save space.

There're still people making UFS/UFS2 as the root partition. I think the above conclusion is aggressive.
CC @delphij

Hmm why me 🤣 I always hated the compression setting here and have all my systems, UFS or ZFS stopped doing compression around 2006, but I wasn't an advocate of doing it one way or another.

Personally, however, I don't think it really matter nowadays even on UFS. Usually, bzip2 achieve a compression ratio of about 11:1 (xz would compress better at expense of slightly slower speed; however, for files at about 1MB, the difference on very old machine is still negligible (within 0.2 seconds per file), and the benefit of faster decompression would be a pretty good argument for using xz as default), but since most of the fast growing files are capped at 1MB, let's say one have fast growing messages and maillog, that would be 14MB vs (let's be generous and assume a compression of 14:1) 1MB, and it's not going to make any difference for any decent modern hardware, even if /var/log is in RAM.

That's said, I'm all *for* disabling compression by default. But I think we should take this a little bit further than simply flipping a default. If I was you I'd probably change the meaning of all compression related flags (J, X, Y, Z) to mean "This file is eligible for compression", and add a new command line option, e.g. --compression= to indicate the compression method to be used, e.g. --compression=legacy means to maintain existing behavior, --compression=none means don't compress at all, --compression=gzip|xz|bzip2|zstd means to use the current Z, X, J, Y behavior, while --compression="gzip -f -9" or --compression=<string> means a custom compression method should be used, and default to --compression=none).

This is a quality-of-life fix, mainly. to make it easier to search all logs with the same command. e.g. you don't have to use bzgrep.

For searching logs, agreed.

In D42961#979432, @0mp wrote:

In D42961#979425, @debdrup wrote:

I think it'd be a good idea to add these as an include - that way, it's easier to enable or disable on a case-by-case basis.

What do you mean by "as an include"?

There are already includes in the file for newsyslog.conf.d/ and the local variant of it.
If I correctly understand how newsyslog works, setting the different values in the include file would override them when the configuration is read by newsyslog?

This is a quality-of-life fix, mainly. to make it easier to search all logs
with the same command. e.g. you don't have to use bzgrep.

If you did not disable compression globally with <compress> none, then you can just use zgrep always, it works on any file, compressed or not, and regardless of compression type. Having it as a short shell alias is a must. Coupled with less configured to use lesspipe.sh (and another short shell alias), I have not had to think about whether a file was compressed both to view or grep it for much longer I can remember.