Page MenuHomeFreeBSD

busdma: emit a warning for use of filters
ClosedPublic

Authored by mhorne on Dec 4 2023, 3:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 10:59 AM
Unknown Object (File)
Mon, Apr 20, 12:12 AM
Unknown Object (File)
Fri, Apr 17, 8:35 PM
Unknown Object (File)
Mon, Mar 30, 5:35 PM
Unknown Object (File)
Mar 25 2026, 12:30 AM
Unknown Object (File)
Mar 20 2026, 7:36 AM
Unknown Object (File)
Mar 20 2026, 7:36 AM
Unknown Object (File)
Mar 9 2026, 1:27 PM
Subscribers

Details

Summary

Filter functions are deprecated, and unused in the tree. If either of
the filter or filterarg arguments to bus_dma_tag_create() are non-NULL,
print a warning.

This is a direct commit to stable/14.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54769
Build 51658: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.Dec 4 2023, 3:49 PM
emaste added inline comments.
sys/arm/arm/busdma_machdep.c
403

maybe "use of busdma filters"?

Although perhaps the man page reference is enough of a clue

This revision is now accepted and ready to land.Dec 4 2023, 6:01 PM

It's a shame we can't print out the name of the offending device. Probably want this in stable/13 as well.

It's a shame we can't print out the name of the offending device.

Indeed - I'm not particularly familiar with this interface but went looking to see if there was a reasonable way to give more information. We could perhaps print a backtrace? In practice though if a user sees this message asking for a (perhaps verbose) dmesg should be sufficient, I'd think.

This revision was automatically updated to reflect the committed changes.