ng_ksocket: fix upcall clearing on node shutdown
ClosedPublic
Actions

Authored by glebius on Nov 16 2023, 4:51 PM.

Details

Reviewers

Group Reviewers

Commits

rG09f4b840bd7c: ng_ksocket: fix upcall clearing on node shutdown
rGefad7cbfdc06: ng_ksocket: fix upcall clearing on node shutdown

Summary

Note: imho, the proper solution would be to guarantee that upcalls
won't ever be called after soclose(), but this isn't the case, yet.
This change at least makes the node work the way it always worked.

PR: 272319
PR: 275106
Fixes: 779f106aa169256b7010a1d8f963ff656b881e92

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Nov 16 2023, 4:51 PM

Herald added subscribers: melifaro, donner, imp. · View Herald TranscriptNov 16 2023, 4:51 PM

glebius requested review of this revision.Nov 16 2023, 4:51 PM

Harbormaster completed remote builds in B54485: Diff 130213.Nov 16 2023, 4:51 PM

glebius added a parent revision: D42635: sockets: don't malloc/free sockaddr memory on accept(2).Nov 16 2023, 4:51 PM

glebius added a child revision: D42637: ng_ksocket: fix accept(2).

afedorov accepted this revision.Nov 17 2023, 7:36 AM

This revision is now accepted and ready to land.Nov 17 2023, 7:36 AM

Closed by commit rGefad7cbfdc06: ng_ksocket: fix upcall clearing on node shutdown (authored by glebius). · Explain WhyNov 17 2023, 5:25 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGefad7cbfdc06: ng_ksocket: fix upcall clearing on node shutdown.

glebius added a commit: rG09f4b840bd7c: ng_ksocket: fix upcall clearing on node shutdown.Nov 30 2023, 5:02 PM

Revision Contents
Changeset List

Path

Size

sys/

netgraph/

ng_ksocket.c

21 lines

Diff 130258

View Options

ng_ksocket: fix upcall clearing on node shutdownClosedPublicActions