Page MenuHomeFreeBSD

dpaa2: defer link_state updates until we are up
ClosedPublic

Authored by bz on Nov 17 2023, 12:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 11, 10:35 AM
Unknown Object (File)
Mon, Mar 9, 12:21 PM
Unknown Object (File)
Mon, Mar 9, 8:00 AM
Unknown Object (File)
Sun, Mar 8, 9:57 PM
Unknown Object (File)
Sun, Mar 8, 5:15 PM
Unknown Object (File)
Sun, Mar 8, 12:46 PM
Unknown Object (File)
Sat, Mar 7, 7:31 PM
Unknown Object (File)
Thu, Mar 5, 10:29 PM
Subscribers

Details

Summary

dpaa2_ni_media_change() was called in early setup stages, before we
were fully setup. That lead to internal state being all synched and
fine but hardware state was lost/never setup corrently.

Introduce dpaa2_ni_media_change_locked() so we can avoid reccursive
locking and call "dpaa2_ni_media_change()" instead of mii_mediachg()
as the latter does not setup our state their either.

In order for this all to work, call if_setdrvflagbits() just before
rather than after the above.

Also remove an unecessary direct call to dpaa2_ni_miibus_statchg()
which mii_mediachg() will trigger anyway.

This all fixes a problem [1] that one had to break the link (either
unplugging/replugging the cable or using ifconfig media none;
ifconfig media auto) to re-trigger the all updates and get the
full state programmed when hardware expected.

MFC after: 3 days
GH-Issue: https://github.com/mcusim/freebsd-src/issues/21 [1]

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54487
Build 51376: arc lint + arc unit