bsd.compat.mk: Set MACHINE before including bsd.opts.mk
ClosedPublic
Actions

Authored by andrew on Nov 2 2023, 5:59 PM.

Tags

None

Referenced Files

	F101734472: D42448.id129656.diff
	Sun, Nov 3, 12:17 AM

	Unknown Object (File)
	Sep 27 2024, 9:51 AM

	Unknown Object (File)
	Sep 22 2024, 4:11 AM

	Unknown Object (File)
	Sep 20 2024, 9:03 PM

	Unknown Object (File)
	Sep 19 2024, 3:36 AM

	Unknown Object (File)
	Sep 18 2024, 12:24 AM

	Unknown Object (File)
	Sep 16 2024, 4:30 PM

	Unknown Object (File)
	Sep 12 2024, 11:34 AM

View All 34 Files

Subscribers

bdrewery

imp

Details

Reviewers

brooks
jhb
jrtc27
emaste
imp

Commits

rG960b4327f49c: bsd.compat.mk: Set MACHINE before including bsd.opts.mk

Summary

In bsd.opts.mk we check MACHINE_ARCH and may want to check MACHINE to
decide which options to enable. Unfortunately this is included too
early via bsd.compiler.mk.

Move including bsd.compiler.mk until after we can set MACHINE and
MACHINE_ARCH.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Nov 2 2023, 5:59 PM

Herald added subscribers: imp, bdrewery. · View Herald TranscriptNov 2 2023, 5:59 PM

andrew requested review of this revision.Nov 2 2023, 5:59 PM

Harbormaster completed remote builds in B54260: Diff 129656.Nov 2 2023, 5:59 PM

Fix buildworld

Harbormaster completed remote builds in B54268: Diff 129679.Nov 3 2023, 12:44 PM

nice catch.

This revision is now accepted and ready to land.Nov 6 2023, 4:36 PM

Closed by commit rG960b4327f49c: bsd.compat.mk: Set MACHINE before including bsd.opts.mk (authored by andrew). · Explain WhyNov 10 2023, 10:08 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG960b4327f49c: bsd.compat.mk: Set MACHINE before including bsd.opts.mk.

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.compat.mk

45 lines

Diff 129930

View Options

bsd.compat.mk: Set MACHINE before including bsd.opts.mkClosedPublicActions