Page MenuHomeFreeBSD

linuxkpi: Fix uses of `pmap_change_attr()`
ClosedPublic

Authored by dumbbell on Oct 2 2023, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 23, 10:58 AM
Unknown Object (File)
Mon, Dec 8, 5:56 PM
Unknown Object (File)
Nov 16 2025, 5:04 AM
Unknown Object (File)
Nov 15 2025, 10:50 PM
Unknown Object (File)
Nov 10 2025, 5:19 AM
Unknown Object (File)
Nov 9 2025, 3:01 AM
Unknown Object (File)
Nov 8 2025, 2:39 AM
Unknown Object (File)
Nov 3 2025, 2:00 AM

Details

Summary

Why

This function takes an offset and a length as argument, not a physical address and a number of pages.

This misuse caused the set_memory_*() and arch_io_reserve_memtype_wc() functions to return EINVAL.

Another problem was the fact that they returned errors as a positive integer, whereas Linux uses negative integers.

How

Physical addresses and number of pages are converted to offset+length in the set_memory_*() functions.

arch_io_reserve_memtype_wc() now calls pmap_change_attr() directly instead of using set_memory_wc().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable