Page MenuHomeFreeBSD

syscall.master: Fix SAL annotation for getdirentires basep argument
ClosedPublic

Authored by guhaoyu2005_gmail.com on Sep 24 2023, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 6:53 PM
Unknown Object (File)
Jun 13 2026, 5:08 PM
Unknown Object (File)
Jun 10 2026, 8:41 AM
Unknown Object (File)
Jun 10 2026, 4:50 AM
Unknown Object (File)
Jun 9 2026, 8:26 PM
Unknown Object (File)
May 13 2026, 7:33 PM
Unknown Object (File)
May 13 2026, 7:32 PM
Unknown Object (File)
May 13 2026, 7:31 PM
Subscribers
None

Details

Summary

As suggested in getdirentires function definition, the last argument "off_t *basep" is an optional output argument. It returns the value only when the passed-in value(pointer) is non-NULL.

This case is very similiar to sendfile, where the second last argument will get a value only when it is non-NULL. The SAL annotation for this argument in syscall.master is defined as _Out_opt_.

This is a part of the research work at RCSLab, University of Waterloo.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53705
Build 50596: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 24 2023, 10:00 PM

Can you confirm that the author (for Git) should be Haoyu Gu <guhaoyu2005@gmail.com>

Can you confirm that the author (for Git) should be Haoyu Gu <guhaoyu2005@gmail.com>

Yes that is correct.