hyperv: vmbus: refactor msg handler by replacing swi with task queue
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Jan 27 2016, 7:50 AM.

Details

Reviewers

howard0su_gmail.com
decui_microsoft.com
delphij
sepherosa_gmail.com
royger
adrian

Summary

swi launches ithread to handle msg from host, which is not efficient
enough. Processing the message directly in task queue during software
interrupt is preferred.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2283
Build 2292: arc lint + arc unit

Event Timeline

honzhan_microsoft.com updated this revision to Diff 12748.Jan 27 2016, 7:50 AM

honzhan_microsoft.com retitled this revision from to hyperv: vmbus: refactor msg handler by replacing swi with task queue.

honzhan_microsoft.com updated this object.

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJan 27 2016, 7:50 AM

honzhan_microsoft.com added reviewers: adrian, decui_microsoft.com, delphij, howard0su_gmail.com, royger, sepherosa_gmail.com.Jan 27 2016, 7:55 AM

howard0su_gmail.com added inline comments.Jan 27 2016, 9:17 AM

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c
539	no need create dedicate task queue. you can use taskqueue_fast directly.

There is another succinct implementation with taskqueue_fast. Please reference https://reviews.freebsd.org/D5215

adrian accepted this revision.Feb 17 2016, 7:12 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Feb 17 2016, 7:12 PM

a different version with same idea is already committed.

sepherosa_gmail.com closed this revision.Sep 13 2016, 8:59 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

vmbus/

hv_vmbus_drv_freebsd.c

58 lines

hv_vmbus_priv.h

4 lines

Diff 12748

View Options

sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c