filter the duplicated route add
Needs ReviewPublic
Actions

Authored by steven_chen3_dell.com on Sep 12 2023, 11:56 AM.

Details

Reviewers

Group Reviewers

Summary

If duplicate adding route table, the route nhop entry is set to multipath entry.
I think that is not a good idea, and it's better to add route as single path if the route hasn't more than one real path.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

steven_chen3_dell.com created this revision.Sep 12 2023, 11:56 AM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptSep 12 2023, 11:56 AM

steven_chen3_dell.com requested review of this revision.Sep 12 2023, 11:56 AM

steven_chen3_dell.com edited the summary of this revision. (Show Details)Sep 12 2023, 12:03 PM

steven_chen3_dell.com updated this revision to Diff 127317.Sep 13 2023, 8:30 AM

steven_chen3_dell.com edited the summary of this revision. (Show Details)Sep 13 2023, 8:47 AM

steven_chen3_dell.com edited the summary of this revision. (Show Details)Sep 13 2023, 9:27 AM

gbe added a subscriber: gbe.Sep 13 2023, 2:31 PM

zlei added a reviewer: network.Sep 27 2023, 12:41 AM

@steven_chen3_dell.com

I'm not getting you the 'duplicate adding route table'.

What is the behavior you expect?

@zlei
There are two same default route tables in my system , and both default route tables only have "Flags" difference(one is UG, another is UGS).
The kernel self cannot guarantee that routes will not be added repeatedly, maybe dhcp client or other user application add the same route entry.

Revision Contents
Changeset List

Path

Size

sys/

net/

route/

route_ctl.c

19 lines

Diff 127317

View Options

filter the duplicated route addNeeds ReviewPublicActions