Page MenuHomeFreeBSD

init_main: Switch from SLIST to STAILQ, fix order
ClosedPublic

Authored by cperciva on Sep 5 2023, 11:48 PM.
Tags
None
Referenced Files
F160456399: D41748.id126984.diff
Wed, Jun 24, 4:18 PM
Unknown Object (File)
Tue, Jun 23, 7:44 AM
Unknown Object (File)
Thu, Jun 11, 1:50 PM
Unknown Object (File)
May 17 2026, 4:55 PM
Unknown Object (File)
May 17 2026, 4:55 PM
Unknown Object (File)
May 16 2026, 11:48 PM
Unknown Object (File)
May 12 2026, 1:41 AM
Unknown Object (File)
May 12 2026, 1:41 AM
Subscribers

Details

Summary

Constructing an SLIST of SYSINITs by inserting them one by one at the
head of the list resulted in them being sorted in anti-stable order:
When two SYSINITs tied for (subsystem, order), they were executed in
the reverse order to the order in which they appeared in the linker
set.

Fixes: 9a7add6d01f3 "init_main: Switch from sysinit array to SLIST"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53453
Build 50344: arc lint + arc unit

Event Timeline

Thank you; this fixes the weird performance problem that we've yet to fully root cause.

This revision is now accepted and ready to land.Sep 6 2023, 4:46 AM