Page MenuHomeFreeBSD
Differential D41587

OpenSSL: Fix handling of the "0:" label in arm-xlate.pl
ClosedPublic
Actions

Authored by jhb on Aug 24 2023, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 9, 11:55 AM
Unknown Object (File)
Wed, Oct 29, 12:24 PM
Unknown Object (File)
Wed, Oct 29, 12:21 PM
Unknown Object (File)
Wed, Oct 29, 12:20 PM
Unknown Object (File)
Wed, Oct 29, 12:20 PM
Unknown Object (File)
Wed, Oct 29, 12:18 PM
Unknown Object (File)
Wed, Oct 29, 7:32 AM
Unknown Object (File)
Wed, Oct 29, 7:32 AM
View All 88 Files
Subscribers
imp

Details

Reviewers
khorben
emaste
markj
andrew
Commits
rGcd8cd03403cc: OpenSSL: Fix handling of the "0:" label in arm-xlate.pl
rGe99406a2bb32: OpenSSL: Fix handling of the "0:" label in arm-xlate.pl
rGeba6abafc198: OpenSSL: Fix handling of the "0:" label in arm-xlate.pl
Summary

When $label == "0", $label is not truthy, so if ($label) thinks there isn't
a label. Correct this by looking at the result of the s/// command.

Verified that there are no changes in the .S files created during a normal
build, and that the "0:" labels appear in the translation given in the error
report (and they are the only difference in the before and after output).

Obtained from: OpenSSL commit 9607f5ccf285ac9988a86f95c5ad9f92b556a843

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53281
Build 50172: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 24 2023, 7:18 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 24 2023, 7:18 PM
Herald added a subscriber: imp. · View Herald Transcript
jhb requested review of this revision.Aug 24 2023, 7:18 PM
jhb added a child revision: D41588: Makefile.asm: Simplify variable expansions in generated headers.
Harbormaster completed remote builds in B53281: Diff 126484.Aug 24 2023, 7:18 PM
jhb added a parent revision: D41568: ossl: Update the generated assembly files from OpenSSL 3.0..Aug 24 2023, 7:52 PM
jhb edited parent revisions, added: D41569: libcrypto: Switch back to the generated assembly in sys/crypto/openssl; removed: D41568: ossl: Update the generated assembly files from OpenSSL 3.0..
markj accepted this revision.Aug 24 2023, 10:39 PM
This revision is now accepted and ready to land.Aug 24 2023, 10:39 PM
Closed by commit rGeba6abafc198: OpenSSL: Fix handling of the "0:" label in arm-xlate.pl (authored by Tom Cosgrove <tom.cosgrove@arm.com>, committed by jhb). · Explain WhyAug 29 2023, 9:47 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGeba6abafc198: OpenSSL: Fix handling of the "0:" label in arm-xlate.pl.
emaste added a commit: rGe99406a2bb32: OpenSSL: Fix handling of the "0:" label in arm-xlate.pl.Sep 22 2023, 7:08 PM
emaste added a commit: rGcd8cd03403cc: OpenSSL: Fix handling of the "0:" label in arm-xlate.pl.Sep 24 2023, 4:19 PM

Revision Contents
Changeset List

PathSize
crypto/
openssl/
crypto/
perlasm/
5 lines

Diff 126484

View Options

crypto/openssl/crypto/perlasm/arm-xlate.pl

Loading...