Page MenuHomeFreeBSD
Differential D41590

libcrypto: Add buildasm and cleanasm targets
ClosedPublic
Actions

Authored by jhb on Aug 24 2023, 7:18 PM.
Tags
None
Referenced Files
F168252929: D41590.id126664.diff
Thu, Aug 27, 4:57 AM
F168107120: D41590.id126664.diff
Wed, Aug 26, 10:25 AM
Unknown Object (File)
Tue, Aug 25, 2:01 AM
Unknown Object (File)
Sat, Aug 22, 6:16 AM
Unknown Object (File)
Sun, Aug 16, 6:44 AM
Unknown Object (File)
Sat, Aug 15, 7:24 AM
Unknown Object (File)
Wed, Aug 12, 9:18 PM
Unknown Object (File)
Mon, Aug 10, 10:19 AM
View All Files
Subscribers
imp

Details

Reviewers
khorben
emaste
markj
Commits
rG1945b8632d68: libcrypto: Add buildasm and cleanasm targets
rGef81451d114e: libcrypto: Add buildasm and cleanasm targets
rG73653b72af65: libcrypto: Add buildasm and cleanasm targets
Summary

These targets generate all the assembly files in sys/crypto/openssl.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Aug 24 2023, 7:18 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 24 2023, 7:18 PM
jhb requested review of this revision.Aug 24 2023, 7:18 PM
jhb added a parent revision: D41589: libcrypto: Refactor Makefile.asm so it can be run outside of buildenv.
Harbormaster completed remote builds in B53284: Diff 126487.Aug 24 2023, 7:18 PM
markj accepted this revision.Aug 28 2023, 4:20 PM
This revision is now accepted and ready to land.Aug 28 2023, 4:20 PM
emaste accepted this revision.Aug 28 2023, 4:42 PM
emaste added inline comments.
secure/lib/libcrypto/Makefile
610

should we stick this list in a variable to share it between the two targets?

jhb added inline comments.Aug 28 2023, 10:04 PM
secure/lib/libcrypto/Makefile
610

Yeah, ASM_ARCHES maybe. Alternatively we could do some kind of funky replacement expression on ${.TARGET} to turn buildasm into all and cleanasm into clean.

Closed by commit rG73653b72af65: libcrypto: Add buildasm and cleanasm targets (authored by jhb). · Explain WhyAug 29 2023, 9:47 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG73653b72af65: libcrypto: Add buildasm and cleanasm targets.
jhb added a commit: rGef81451d114e: libcrypto: Add buildasm and cleanasm targets.Sep 8 2023, 8:58 PM
emaste added a commit: rG1945b8632d68: libcrypto: Add buildasm and cleanasm targets.Oct 25 2023, 8:07 PM

Revision Contents
Changeset List

PathSize
secure/
lib/
libcrypto/
7 lines
2 lines

Diff 126664

View Options

secure/lib/libcrypto/Makefile

Loading...
View Options

secure/lib/libcrypto/Makefile.common

Loading...