pf: fix failure to log correct action through default rule
AbandonedPublic
Actions

Authored by franco_opnsense.org on Aug 24 2023, 9:34 AM.

Details

Reviewers

Summary

The default rule is used to call PFLOG_PACKET macro and the reason
is given directly for when e.g. PFRES_SHORT is invoked and PF_DROP
is carried out. However, the action is not passed down directly so
action needs to be adjusted when the default rule made the decision
due to a non-matching reason, which means PF_DROP.

OpenBSD fix: https://github.com/openbsd/src/commit/7b8683a1743e7

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 53263
Build 50154: arc lint + arc unit

Event Timeline

franco_opnsense.org created this revision.Aug 24 2023, 9:34 AM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptAug 24 2023, 9:34 AM

franco_opnsense.org requested review of this revision.Aug 24 2023, 9:34 AM

Harbormaster completed remote builds in B53263: Diff 126452.Aug 24 2023, 9:34 AM

franco_opnsense.org added a reviewer: kp.Aug 24 2023, 9:35 AM

style update

Harbormaster completed remote builds in B53264: Diff 126453.Aug 24 2023, 9:39 AM

@kp when you said "Supporting opnsense is your job, not mine. You don’t get to just throw bugs over the wall without doing any actual testing on freebsd."[1] I'm unsure if you really meant this or if you simply don't react because it's not important to you or FreeBSD?

I can live with begging for fixes or just for them to be comitted, but I don't appreciate the attitude you have towards contributors.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273207

OpenBSD fix: https://github.com/openbsd/src/commit/7b8683a1743e7

switch to OpenBSD approach

Harbormaster completed remote builds in B54307: Diff 129798.Nov 6 2023, 8:44 PM

franco_opnsense.org edited the summary of this revision. (Show Details)Nov 6 2023, 8:47 PM

Maybe fixed, who knows ;)

Herald added a subscriber: vegeta_tuxpowered.net. · View Herald TranscriptMay 24 2024, 4:08 PM