Page MenuHomeFreeBSD
Differential D41536

libcrypto: Don't embed $FreeBSD$ in generated assembly files
ClosedPublic
Actions

Authored by jhb on Aug 21 2023, 10:06 PM.
Tags
None
Referenced Files
F137750355: D41536.id.diff
Tue, Nov 25, 11:43 AM
Unknown Object (File)
Fri, Nov 21, 7:27 AM
Unknown Object (File)
Sun, Nov 16, 2:31 PM
Unknown Object (File)
Tue, Nov 11, 12:32 AM
Unknown Object (File)
Wed, Oct 29, 9:52 AM
Unknown Object (File)
Wed, Oct 29, 9:51 AM
Unknown Object (File)
Oct 24 2025, 10:26 PM
Unknown Object (File)
Oct 17 2025, 5:23 AM
View All Files
Subscribers
imp

Details

Reviewers
khorben
emaste
gallatin
ngie
Commits
rG8f54a610e00d: libcrypto: Don't embed $FreeBSD$ in generated assembly files
rG7a56f5af7185: libcrypto: Don't embed $FreeBSD$ in generated assembly files

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53218
Build 50109: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 21 2023, 10:06 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 21 2023, 10:06 PM
jhb requested review of this revision.Aug 21 2023, 10:06 PM
Harbormaster completed remote builds in B53218: Diff 126338.Aug 21 2023, 10:06 PM
jhb added a child revision: D41537: libcrypto: Add new assembly files added in OpenSSL 3.0..Aug 21 2023, 10:06 PM
emaste accepted this revision.Aug 21 2023, 10:52 PM
emaste added inline comments.
secure/lib/libcrypto/Makefile.asm
54

We might want to do the @generated while we're at it

This revision is now accepted and ready to land.Aug 21 2023, 10:52 PM
emaste added a reviewer: ngie.Aug 21 2023, 10:52 PM
gallatin accepted this revision.Aug 21 2023, 11:20 PM
ngie accepted this revision.Aug 22 2023, 12:17 AM
jhb added inline comments.Aug 22 2023, 3:23 AM
secure/lib/libcrypto/Makefile.asm
54

Hmm, perhaps as a separate followup as that will require regenerating all the files.

emaste added a comment.Aug 22 2023, 3:53 AM

Hmm, perhaps as a separate followup as that will require regenerating all the files.

Sounds good, a separate commit if at all

Closed by commit rG7a56f5af7185: libcrypto: Don't embed $FreeBSD$ in generated assembly files (authored by jhb). · Explain WhyAug 22 2023, 4:05 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG7a56f5af7185: libcrypto: Don't embed $FreeBSD$ in generated assembly files.
imp added a commit: rG8f54a610e00d: libcrypto: Don't embed $FreeBSD$ in generated assembly files.Aug 23 2023, 5:59 PM

Revision Contents
Changeset List

PathSize
secure/
lib/
libcrypto/
57 lines

Diff 126338

View Options

secure/lib/libcrypto/Makefile.asm

Loading...