One thing of interest to reviewers here: how should we (meaning me) best coordinate matching updates of nvidia-drm-kmod with updates to nvidia-driver? nvidia-drm-kmod isn't as simple as bumping a version number since I have to populate a driver branch in github for a particular version.

I'm guessing just CC'ing me on PRs for bumping nvidia-driver and I'll do the equivalent nvidia-drm-kmod update will be easiest, but figured I would bring that up in case anyone has suggestions or concerns.

I have to populate a driver branch in github for a particular version.

Is this purely mechanical? You just copy some stuff from the upstream tarball to your branch?

It's documented here: https://github.com/amshafer/nvidia-driver/blob/535.86.05/UPDATING.md

Mostly mechanical but not completely automated yet. About half the time there's small issues to fix, like updating the FreeBSD makefile with missing bits that have been added to the Linux version. Usually a ~15 minute process for me.

Ok, it is anyways not a problem. When the nvidia-driver port gets updated, the nvidia-drm port will pull in the new NVIDIA_DISTVERSION, which will make distinfo invalid. The package builder then fail to build nvidia-drm and send you a mail. This can be regarded as automatic "CC'ing on update".

What can we set the LICENSE= knob to?

Setting LICENSE_FILE= ${WRKSRC}/nvidia/doc/license.txt in Makefile.common should be fine for the child ports, but for the metaport I'm not sure the best way to include that? For nvidia-drm-kmod should I just copy that license file in the directory and reference that in LICENSE_FILE?

LICENSE_FILE is optional. I'm interested in LICENSE itself. It is your work, right? You can choose whatever license you like.

The code is still NVIDIA code, I've just modified it for compatability. The nvidia-drm-kmod port's Makefile is mine though, is that what you're referring to? I think the license of nvidia-drm-kmod should match the child ports to avoid anyone getting confused and thinking nvidia-drm.ko is BSD licensed.