Page MenuHomeFreeBSD
Differential D41486

arm64 db_trace: Ensure trapframe pointer is suitably aligned.
ClosedPublic
Actions

Authored by jhb on Aug 16 2023, 11:00 PM.
Tags
None
Referenced Files
F171548829: D41486.id126100.diff
Fri, Sep 11, 5:09 PM
F171539389: D41486.id.diff
Fri, Sep 11, 4:02 PM
Unknown Object (File)
Fri, Sep 11, 12:26 PM
Unknown Object (File)
Wed, Sep 9, 5:15 AM
Unknown Object (File)
Wed, Sep 9, 12:09 AM
Unknown Object (File)
Tue, Sep 8, 6:08 PM
Unknown Object (File)
Sat, Sep 5, 8:37 PM
Unknown Object (File)
Sat, Sep 5, 4:53 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
andrew
markj
jrtc27
manu
Commits
rG638c68897fbd: arm64 db_trace: Ensure trapframe pointer is suitably aligned.
Summary

Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53142
Build 50033: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 16 2023, 11:00 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 16 2023, 11:00 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
jhb requested review of this revision.Aug 16 2023, 11:00 PM
Harbormaster completed remote builds in B53142: Diff 126100.Aug 16 2023, 11:00 PM
jrtc27 accepted this revision.Aug 17 2023, 12:19 AM
This revision is now accepted and ready to land.Aug 17 2023, 12:19 AM
jrtc27 added a comment.Aug 17 2023, 12:20 AM

Will you be doing the same for riscv?

markj accepted this revision.Aug 17 2023, 2:30 PM

DTrace stack unwinders need similar checks. I'll take care of that.

jhb added a comment.Aug 17 2023, 6:28 PM
In D41486#945017, @jrtc27 wrote:

Will you be doing the same for riscv?

Mmm, I can. Just about all of the kstack_contains callers probably need this type of check as well I imagine.

Closed by commit rG638c68897fbd: arm64 db_trace: Ensure trapframe pointer is suitably aligned. (authored by jhb). · Explain WhyAug 17 2023, 6:32 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG638c68897fbd: arm64 db_trace: Ensure trapframe pointer is suitably aligned..

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
3 lines

Diff 126100

View Options

sys/arm64/arm64/db_trace.c

Loading...