Page MenuHomeFreeBSD
Differential D41448

Buffering syslogd output to pipe
Needs ReviewPublic
Actions

Authored by slw_zxy.spb.ru on Aug 14 2023, 3:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 5, 2:15 PM
Unknown Object (File)
Sat, Apr 4, 11:23 PM
Unknown Object (File)
Sat, Apr 4, 4:26 AM
Unknown Object (File)
Sat, Apr 4, 2:00 AM
Unknown Object (File)
Fri, Apr 3, 10:28 PM
Unknown Object (File)
Fri, Apr 3, 8:36 PM
Unknown Object (File)
Wed, Apr 1, 8:51 AM
Unknown Object (File)
Sun, Mar 29, 10:48 PM
View All Files
Subscribers
imp

Details

Reviewers
jfree
emaste
markj
eugen_grosbein.net
Group Reviewers
Contributor Reviews (src)
Summary

syslogd currently does O_NONBLOCK output to pipe. As a result any micro-burst can cause an overflow of the pipe buffer (64KB) and kill the script.
Patch allows to buffer (-g SIZE total bytes) for up to 10 seconds per script before killing script.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

slw_zxy.spb.ru created this revision.Aug 14 2023, 3:08 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 14 2023, 3:08 PM
slw_zxy.spb.ru requested review of this revision.Aug 14 2023, 3:08 PM
arrowd edited the summary of this revision. (Show Details)Aug 14 2023, 3:21 PM
arrowd added a reviewer: Contributor Reviews (src).
afedorov added reviewers: jfree, emaste, markj.Aug 14 2023, 3:51 PM
slw_zxy.spb.ru updated this revision to Diff 125977.Aug 14 2023, 4:34 PM

auto-tuning by hw.usermem and use __XSTRING

eugen_grosbein.net added a reviewer: eugen_grosbein.net.Aug 14 2023, 4:43 PM
markj added a comment.Aug 14 2023, 4:53 PM

I plan to commit a number of syslogd patches this week (some refactoring from @jfree in preparation for running syslogd under Capsicum, see the patch stack starting with D41357), so please hold off on committing this for a bit.

/usr/src/usr.sbin/syslogd/syslogd.c
1995

cnt is size_t, an unsigned type, so this check is always false. It should be ssize_t.

slw_zxy.spb.ru updated this revision to Diff 125980.Aug 14 2023, 5:04 PM

cnt is size_t, an unsigned type, so this check is always false. It should be ssize_t.

slw_zxy.spb.ru added a comment.Aug 14 2023, 5:10 PM
In D41448#943957, @markj wrote:

I plan to commit a number of syslogd patches this week (some refactoring from @jfree in preparation for running syslogd under Capsicum, see the patch stack starting with D41357), so please hold off on committing this for a bit.

I can tailor a patch to fit your changes so you can commit it too.

slw_zxy.spb.ru updated this revision to Diff 125982.Aug 14 2023, 5:20 PM
slw_zxy.spb.ru updated this revision to Diff 128084.Oct 2 2023, 4:06 PM

Update to latest syslogd changes

Revision Contents
Changeset List

PathSize
usr/
src/
usr.sbin/
syslogd/
home/
admin/
stable.13/
usr.sbin/
syslogd/
228 lines

Diff 125982

View Options

/usr/src/usr.sbin/syslogd/syslogd.c

Loading...