Page MenuHomeFreeBSD
Differential D41353

nvme: Directly lookup op code
ClosedPublic
Actions

Authored by imp on Aug 7 2023, 10:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 2, 6:20 PM
Unknown Object (File)
Mon, Mar 2, 3:26 PM
Unknown Object (File)
Wed, Feb 18, 8:43 AM
Unknown Object (File)
Tue, Feb 17, 7:43 AM
Unknown Object (File)
Feb 8 2026, 2:44 PM
Unknown Object (File)
Feb 8 2026, 9:07 AM
Unknown Object (File)
Feb 6 2026, 12:26 PM
Unknown Object (File)
Jan 30 2026, 7:25 PM
View All 99 Files
Subscribers
dab

Details

Reviewers
jhb
chuck
mav
Commits
rG2ad9a815fd58: nvme: Directly lookup op code
Summary

Rather than have a table to walk through, use a sparse array.

Suggested by: jhb
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53008
Build 49899: arc lint + arc unit

Event Timeline

imp created this revision.Aug 7 2023, 10:12 PM
Herald added a subscriber: dab. · View Herald TranscriptAug 7 2023, 10:12 PM
imp requested review of this revision.Aug 7 2023, 10:12 PM
Harbormaster completed remote builds in B53008: Diff 125673.Aug 7 2023, 10:12 PM
imp mentioned this in D41310: nvme: Eliminate redundant code.Aug 7 2023, 10:13 PM
imp added a parent revision: D41311: nvme: Add more NVME Base Spec 2.0 and NVME Command Set Spec 1.0a.
imp added a child revision: D41312: nvme: Convert adjacent bools to a bitfield.
jhb accepted this revision.Aug 7 2023, 10:45 PM
jhb added inline comments.
sys/dev/nvme/nvme_qpair.c
105

I do think you can change the opc type to uint8_t and then you can remove the check against DEFAULT_INDEX.

This revision is now accepted and ready to land.Aug 7 2023, 10:45 PM
Closed by commit rG2ad9a815fd58: nvme: Directly lookup op code (authored by imp). · Explain WhyAug 7 2023, 10:47 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG2ad9a815fd58: nvme: Directly lookup op code.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
114 lines

Diff 125673

View Options

sys/dev/nvme/nvme_qpair.c

Loading...