Page MenuHomeFreeBSD
Differential D41320

tests: Add stack grows tests
ClosedPublic
Actions

Authored by dchagin on Aug 4 2023, 12:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 19, 3:19 PM
Unknown Object (File)
Sat, Oct 19, 7:40 AM
Unknown Object (File)
Sep 28 2024, 6:07 PM
Unknown Object (File)
Sep 28 2024, 4:24 PM
Unknown Object (File)
Sep 24 2024, 6:15 AM
Unknown Object (File)
Sep 24 2024, 3:56 AM
Unknown Object (File)
Sep 24 2024, 3:56 AM
Unknown Object (File)
Sep 24 2024, 3:32 AM
View All 87 Files
Subscribers
ehem_freebsd_m5p.com
imp

Details

Reviewers
kib
jrtc27
Commits
rG0234b6d17f50: tests: Add stack grows tests
rG8920c5f2a117: tests: Add stack grows tests
Summary

There's a depedndency stack_dt_need_test:soxstack issue that I don't understand how to fix properly

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52994
Build 49885: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 4 2023, 12:46 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 4 2023, 12:46 PM
dchagin requested review of this revision.Aug 4 2023, 12:46 PM
Harbormaster completed remote builds in B52978: Diff 125582.Aug 4 2023, 12:46 PM
dchagin retitled this revision from tests: Add stack grows tests There's a depedndency stack_dt_need_test:soxstack issue that I don't understand how to fix properly to tests: Add stack grows tests.Aug 4 2023, 12:47 PM
dchagin edited the summary of this revision. (Show Details)
dchagin added reviewers: kib, jrtc27.
kib added a comment.Aug 5 2023, 8:52 AM

I am not sure what your trouble is, but if it is about having the dependency .dso built before the test program, try to look at libexec/rtld-elf/tests/Makefile. Specifically SUBDIR_DEPEND_target= XXX.

dchagin updated this revision to Diff 125629.Aug 6 2023, 6:50 AM
dchagin edited the summary of this revision. (Show Details)

John Carr test added

Harbormaster completed remote builds in B52993: Diff 125629.Aug 6 2023, 6:50 AM
dchagin added a comment.Aug 6 2023, 6:53 AM
In D41320#941149, @kib wrote:

I am not sure what your trouble is, but if it is about having the dependency .dso built before the test program, try to look at libexec/rtld-elf/tests/Makefile. Specifically SUBDIR_DEPEND_target= XXX.

It works only in case when the _target is a directory

jrtc27 added a comment.Aug 6 2023, 7:01 AM
In D41320#941219, @dchagin wrote:
In D41320#941149, @kib wrote:

I am not sure what your trouble is, but if it is about having the dependency .dso built before the test program, try to look at libexec/rtld-elf/tests/Makefile. Specifically SUBDIR_DEPEND_target= XXX.

It works only in case when the _target is a directory

Put .WAIT in SUBDIR before them

dchagin updated this revision to Diff 125630.Aug 6 2023, 10:13 AM

Move stack tests to a separate directory under tests/sys/vm

Harbormaster completed remote builds in B52994: Diff 125630.Aug 6 2023, 10:13 AM
kib added inline comments.Aug 6 2023, 11:12 AM
tests/sys/vm/stack/stack_mprotect_exec_test.c
32

Does this magic value depend on the generated code? Same question about the arch.

In other words, would the test require tweaking for each compiler import?

dchagin updated this revision to Diff 125639.Aug 6 2023, 9:24 PM

well, that's was John's test case, adapted to atf. I agree, that te test was a bit clumsy,
so, slightly rework it. AFAIU, the test changes the protection bits of the last page in the mmaped
stack area, then touches next page to gen PF.

Harbormaster completed remote builds in B52999: Diff 125639.Aug 6 2023, 9:24 PM
dchagin marked an inline comment as done.Aug 6 2023, 9:25 PM
kib accepted this revision.Aug 6 2023, 10:12 PM
In D41320#941305, @dchagin wrote:

well, that's was John's test case, adapted to atf. I agree, that te test was a bit clumsy,
so, slightly rework it. AFAIU, the test changes the protection bits of the last page in the mmaped
stack area, then touches next page to gen PF.

Exactly, so removing the magic 0x20, which is apparently not needed, is only good.

This revision is now accepted and ready to land.Aug 6 2023, 10:12 PM
jrtc27 added inline comments.Aug 6 2023, 10:21 PM
tests/sys/vm/Makefile
21

Why is this in SUBDIR rather than TESTS_SUBDIRS? Though now the library is in a subdir just use the normal SUBDIR_DEPENDS_?

dchagin added inline comments.Aug 7 2023, 10:26 AM
tests/sys/vm/Makefile
21

Just a leftover after .WAIT experiments, will fix. Looks like SUBDIR_DEPENDS_ works only if _target is a directory

dchagin updated this revision to Diff 125658.Aug 7 2023, 2:13 PM

SUBDIR_DEPENDS_stack

This revision now requires review to proceed.Aug 7 2023, 2:13 PM
Harbormaster completed remote builds in B53005: Diff 125658.Aug 7 2023, 2:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2023, 3:12 PM
Closed by commit rG8920c5f2a117: tests: Add stack grows tests (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG8920c5f2a117: tests: Add stack grows tests.
ehem_freebsd_m5p.com added a subscriber: ehem_freebsd_m5p.com.Aug 8 2023, 8:12 PM

At the end of a full build which just terminated:

ld: error: unable to find library -lsoxstack
clang: error: linker command failed with exit code 1 (use -v to see invocation)
--- stack_dt_need_exec_test.full ---
*** [stack_dt_need_exec_test.full] Error code 1

Looks like this broke the build.

ehem_freebsd_m5p.com added a comment.Aug 8 2023, 9:37 PM

Rebuild with 8920c5f2a11 reverted succeeded. Looks like D41320. The host is FreeBSD 13.2p2 with minimal extras.

dchagin added a comment.Aug 8 2023, 9:41 PM
In D41320#942212, @ehem_freebsd_m5p.com wrote:

Rebuild with 8920c5f2a11 reverted succeeded. Looks like D41320. The host is FreeBSD 13.2p2 with minimal extras.

try 76f28f65, thanks.

dchagin added a commit: rG0234b6d17f50: tests: Add stack grows tests.Aug 27 2023, 7:33 AM

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
tests/
sys/
vm/
5 lines
soxstack/
17 lines
51 lines
stack/
15 lines
64 lines
50 lines
45 lines

Diff 125630

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

tests/sys/vm/Makefile

Loading...
View Options

tests/sys/vm/soxstack/Makefile

Loading...
View Options

tests/sys/vm/soxstack/soxstack.c

Loading...
View Options

tests/sys/vm/stack/Makefile

Loading...
View Options

tests/sys/vm/stack/stack_dlopen_exec_test.c

Loading...
View Options

tests/sys/vm/stack/stack_dt_need_exec_test.c

Loading...
View Options

tests/sys/vm/stack/stack_mprotect_exec_test.c

Loading...