tests: Add stack grows tests

[dchagin]

Summary

There's a depedndency stack_dt_need_test:soxstack issue that I don't understand how to fix properly

[kib]

I am not sure what your trouble is, but if it is about having the dependency .dso built before the test program, try to look at libexec/rtld-elf/tests/Makefile. Specifically SUBDIR_DEPEND_target= XXX.

[dchagin]

John Carr test added

[dchagin]

In D41320#941149, @kib wrote:

I am not sure what your trouble is, but if it is about having the dependency .dso built before the test program, try to look at libexec/rtld-elf/tests/Makefile. Specifically SUBDIR_DEPEND_target= XXX.

It works only in case when the _target is a directory

[jrtc27]

In D41320#941219, @dchagin wrote:

In D41320#941149, @kib wrote:

I am not sure what your trouble is, but if it is about having the dependency .dso built before the test program, try to look at libexec/rtld-elf/tests/Makefile. Specifically SUBDIR_DEPEND_target= XXX.

It works only in case when the _target is a directory

Put .WAIT in SUBDIR before them

[dchagin]

Move stack tests to a separate directory under tests/sys/vm

[kib]

tests/sys/vm/stack/stack_mprotect_exec_test.c

33

Does this magic value depend on the generated code? Same question about the arch.

In other words, would the test require tweaking for each compiler import?

[dchagin]

well, that's was John's test case, adapted to atf. I agree, that te test was a bit clumsy,
so, slightly rework it. AFAIU, the test changes the protection bits of the last page in the mmaped
stack area, then touches next page to gen PF.

[kib]

In D41320#941305, @dchagin wrote:

well, that's was John's test case, adapted to atf. I agree, that te test was a bit clumsy,
so, slightly rework it. AFAIU, the test changes the protection bits of the last page in the mmaped
stack area, then touches next page to gen PF.

Exactly, so removing the magic 0x20, which is apparently not needed, is only good.

[jrtc27]

tests/sys/vm/Makefile

21

Why is this in SUBDIR rather than TESTS_SUBDIRS? Though now the library is in a subdir just use the normal SUBDIR_DEPENDS_?

[dchagin]

tests/sys/vm/Makefile

21

Just a leftover after .WAIT experiments, will fix. Looks like SUBDIR_DEPENDS_ works only if _target is a directory

[dchagin]

SUBDIR_DEPENDS_stack

[ehem_freebsd_m5p.com]

At the end of a full build which just terminated:

ld: error: unable to find library -lsoxstack
clang: error: linker command failed with exit code 1 (use -v to see invocation)
--- stack_dt_need_exec_test.full ---
*** [stack_dt_need_exec_test.full] Error code 1

Looks like this broke the build.

[ehem_freebsd_m5p.com]

Rebuild with 8920c5f2a11 reverted succeeded. Looks like D41320. The host is FreeBSD 13.2p2 with minimal extras.

[dchagin]

In D41320#942212, @ehem_freebsd_m5p.com wrote:

Rebuild with 8920c5f2a11 reverted succeeded. Looks like D41320. The host is FreeBSD 13.2p2 with minimal extras.

try 76f28f65, thanks.