vmm: don't return random error from vcpu_lock_all() if vcpu is empty
ClosedPublic
Actions

Authored by glebius on Jul 12 2023, 4:17 AM.

Details

Reviewers

corvink
markj

Group Reviewers

bhyve

Commits

rG30f0328a322e: vmm: don't return random error from vcpu_lock_all() if vcpu is empty

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52571
Build 49462: arc lint + arc unit

Event Timeline

glebius created this revision.Jul 12 2023, 4:17 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJul 12 2023, 4:17 AM

glebius requested review of this revision.Jul 12 2023, 4:17 AM

Harbormaster completed remote builds in B52571: Diff 124526.Jul 12 2023, 4:17 AM

glebius added a child revision: D40981: vmm: don't leak locks exiting vmmdev_ioctl().Jul 12 2023, 4:18 AM

glebius mentioned this in D40981: vmm: don't leak locks exiting vmmdev_ioctl().Jul 12 2023, 4:19 AM

Have you seen a situation where vcpu_lock_all returned a random error? If yes, please describe it in the commit message.

This revision is now accepted and ready to land.Jul 12 2023, 5:37 AM

markj accepted this revision as: markj.Jul 12 2023, 12:53 PM

Closed by commit rG30f0328a322e: vmm: don't return random error from vcpu_lock_all() if vcpu is empty (authored by glebius). · Explain WhyJul 12 2023, 4:18 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG30f0328a322e: vmm: don't return random error from vcpu_lock_all() if vcpu is empty.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

vmm_dev.c

1 line

Diff 124526

View Options

vmm: don't return random error from vcpu_lock_all() if vcpu is emptyClosedPublicActions