Differential D40981

vmm: don't leak locks exiting vmmdev_ioctl()
ClosedPublic
Actions

Authored by glebius on Jul 12 2023, 4:17 AM.

Tags

None

Referenced Files

	F167734576: D40981.diff
	Mon, Aug 24, 3:27 AM

	Unknown Object (File)
	Sat, Aug 22, 6:22 AM

	Unknown Object (File)
	Fri, Aug 14, 4:18 AM

	Unknown Object (File)
	Thu, Aug 13, 7:19 PM

	Unknown Object (File)
	Wed, Aug 12, 1:06 PM

	Unknown Object (File)
	Sat, Aug 8, 11:33 PM

	Unknown Object (File)
	May 2 2026, 4:57 PM

	Unknown Object (File)
	May 1 2026, 2:59 PM

View All 77 Files

Subscribers

Details

Reviewers

corvink
markj

Group Reviewers

Commits

rG0d1ff2b04d27: vmm: don't leak locks exiting vmmdev_ioctl()

Summary

At least an error from vcpu_lock_all() at line 553 would leak
memseg lock. There might be other cases as well.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jul 12 2023, 4:17 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJul 12 2023, 4:17 AM

glebius requested review of this revision.Jul 12 2023, 4:17 AM

Harbormaster completed remote builds in B52572: Diff 124527.Jul 12 2023, 4:17 AM

glebius added a parent revision: D40980: vmm: don't return random error from vcpu_lock_all() if vcpu is empty.Jul 12 2023, 4:18 AM

This and D40980 are now required for me to use bhyve. Without them it panics with 100% guarantee. I don't know what is special with my machine that vcpu array is empty during early stages of bhyveload. With the patches, bhyve just works and VM boots up. Apparently vcpus are allocated later.

corvink accepted this revision.Jul 12 2023, 5:39 AM

This revision is now accepted and ready to land.Jul 12 2023, 5:39 AM

markj accepted this revision as: markj.Jul 12 2023, 12:53 PM

Closed by commit rG0d1ff2b04d27: vmm: don't leak locks exiting vmmdev_ioctl() (authored by glebius). · Explain WhyJul 12 2023, 4:18 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG0d1ff2b04d27: vmm: don't leak locks exiting vmmdev_ioctl().

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

2 lines

Diff 124576

sys/amd64/vmm/vmm_dev.c

Loading...