Differential D40911

pf: use sctp_calculate_cksum()
ClosedPublic
Actions

Authored by kp on Jul 7 2023, 2:38 PM.

Details

Reviewers

None

Group Reviewers

network

Commits

rG836dc3507e0d: pf: use sctp_calculate_cksum()
rG61e22e9b2905: pf: use sctp_calculate_cksum()

Summary

This function is always available, even if the SCTP or SCTP_SUPPORT options
are not set.
That lets us remove an ifdef, and also means we improve pf's SCTP handling
when the options are not set.

MFC after: 3 weeks
Sponsored by: Orange Business Services

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52479
Build 49370: arc lint + arc unit

Event Timeline

kp created this revision.Jul 7 2023, 2:38 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptJul 7 2023, 2:38 PM

kp requested review of this revision.Jul 7 2023, 2:38 PM

Harbormaster completed remote builds in B52479: Diff 124282.Jul 7 2023, 2:38 PM

kp added a child revision: D40861: pfctl: SCTP can have port numbers.Jul 7 2023, 2:39 PM

emaste mentioned this in D41111: status 2023q3: add pf status report.Jul 20 2023, 5:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2023, 10:33 AM

Closed by commit rG61e22e9b2905: pf: use sctp_calculate_cksum() (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG61e22e9b2905: pf: use sctp_calculate_cksum().

kp added a commit: rG836dc3507e0d: pf: use sctp_calculate_cksum().Aug 11 2023, 12:13 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

22 lines

Diff 124282

View Options

pf: use sctp_calculate_cksum()ClosedPublicActions