Page MenuHomeFreeBSD

arm64: Fix a use of update_lower_register
ClosedPublic

Authored by andrew on Jul 3 2023, 11:04 AM.
Tags
None
Referenced Files
F170797790: D40846.diff
Sun, Sep 6, 4:55 PM
F170769361: D40846.id.diff
Sun, Sep 6, 1:00 PM
Unknown Object (File)
Sun, Sep 6, 5:31 AM
Unknown Object (File)
Sun, Sep 6, 12:39 AM
Unknown Object (File)
Sat, Sep 5, 8:19 PM
Unknown Object (File)
Sat, Sep 5, 11:22 AM
Unknown Object (File)
Sat, Sep 5, 11:06 AM
Unknown Object (File)
Sat, Sep 5, 7:05 AM

Details

Summary

In get_kernel_reg_masked we use update_lower_register to get the lower
value of two registers for a given field. It will return the entire
register value with just the single field updated.

Because of this get_kernel_reg_masked needs to use the returned value
directly rather than ORing each field together. Fix this by updating
the mask and returning that from get_kernel_reg_masked.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 4 2023, 2:38 PM
christos added inline comments.
sys/arm64/arm64/identcpu.c
1829

Did you mean valp instead?

This revision was automatically updated to reflect the committed changes.