hyperv/hn: Use m_copydata for chimney sending.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jan 18 2016, 8:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 24, 8:46 AM

	Unknown Object (File)
	Thu, Apr 24, 6:53 AM

	Unknown Object (File)
	Sun, Apr 20, 8:25 PM

	Unknown Object (File)
	Mon, Apr 14, 7:26 AM

	Unknown Object (File)
	Mon, Apr 14, 2:43 AM

	Unknown Object (File)
	Mon, Apr 14, 2:12 AM

	Unknown Object (File)
	Mar 11 2025, 4:36 AM

	Unknown Object (File)
	Feb 10 2025, 9:44 AM

View All 70 Files

Subscribers

freebsd-net-list

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
adrian

Group Reviewers

network

Commits

rS294701: hyperv/hn: Use m_copydata for chimney sending.

Summary

While I'm here, move stack variables near their usage.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

If no objection comes, it will be committed two days later

howard0su_gmail.com added inline comments.Jan 18 2016, 2:12 PM

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
947	why uint8? the last parameter is caddr_t m_copydata(const struct mbuf mbuf, int offset, int len, caddr_t buf);

sepherosa_gmail.com added inline comments.Jan 18 2016, 3:03 PM

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
947	caddr_t is char , I generally like to use uint8_t for byte array, instead of char . I don't think we have -Wpointer-sign in kernel compiling cc flags, so uint8_t has same effect as char */caddr_t for m_copydata()

Looks good to me.

This revision is now accepted and ready to land.Jan 19 2016, 1:28 AM

adrian accepted this revision.Jan 22 2016, 3:52 AM

adrian edited edge metadata.

Closed by commit rS294701: hyperv/hn: Use m_copydata for chimney sending. (authored by sephe). · Explain WhyJan 25 2016, 5:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

netvsc/

hv_netvsc_drv_freebsd.c

23 lines

Diff 12412

View Options

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

hyperv/hn: Use m_copydata for chimney sending.ClosedPublicActions