Page MenuHomeFreeBSD

arm64: Fix a use of update_lower_register
ClosedPublic

Authored by andrew on Jul 3 2023, 11:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 22, 6:54 PM
Unknown Object (File)
Sat, Aug 22, 11:45 AM
Unknown Object (File)
Fri, Aug 21, 3:19 PM
Unknown Object (File)
Tue, Aug 18, 7:44 PM
Unknown Object (File)
Sun, Aug 16, 5:06 PM
Unknown Object (File)
Tue, Aug 11, 10:54 PM
Unknown Object (File)
Tue, Aug 11, 10:54 PM
Unknown Object (File)
Tue, Aug 11, 10:53 PM

Details

Summary

In get_kernel_reg_masked we use update_lower_register to get the lower
value of two registers for a given field. It will return the entire
register value with just the single field updated.

Because of this get_kernel_reg_masked needs to use the returned value
directly rather than ORing each field together. Fix this by updating
the mask and returning that from get_kernel_reg_masked.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52394
Build 49285: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 4 2023, 2:38 PM
christos added inline comments.
sys/arm64/arm64/identcpu.c
1829

Did you mean valp instead?

This revision was automatically updated to reflect the committed changes.