Page MenuHomeFreeBSD
Differential D40749

libcrypto: build nistp* on powerpc64le and riscv64
ClosedPublic
Actions

Authored by emaste on Jun 24 2023, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 11:38 AM
Unknown Object (File)
Mon, Apr 20, 10:47 PM
Unknown Object (File)
Mon, Apr 20, 6:56 PM
Unknown Object (File)
Mon, Apr 20, 12:50 PM
Unknown Object (File)
Sun, Apr 19, 9:39 PM
Unknown Object (File)
Sat, Apr 18, 10:44 AM
Unknown Object (File)
Wed, Apr 15, 10:39 PM
Unknown Object (File)
Wed, Apr 15, 10:29 PM
View All Files
Subscribers
imp
jrtc27
lwhsu

Details

Reviewers
ngie
khorben
jrtc27
Commits
rG9cbc371c8af7: libcrypto: build nistp* on all little-endian 64-bit targets
Summary

libcrypto intends to provide these routines on little-endian 64-bit targets.

Reported by:    ci.freebsd.org
Sponsored by:   The FreeBSD Foundation
Test Plan

make tinderbox in progress

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 24 2023, 5:57 PM
emaste created this revision.
emaste added inline comments.
secure/lib/libcrypto/Makefile
234

I'm not sure if ASM_riscv64 gets defined or not

emaste updated this revision to Diff 123723.Jun 24 2023, 6:01 PM

Define ASM_riscv64

emaste added a subscriber: lwhsu.Jun 24 2023, 6:04 PM
emaste added inline comments.Jun 24 2023, 6:41 PM
secure/lib/libcrypto/Makefile
234

Of course ASM_* isn't really right variable name for something controlling C files, but it's consistent with what's already here, and we may have riscv64 asm files in the future.

jrtc27 added a subscriber: jrtc27.Jun 24 2023, 7:42 PM

These should really be gated by ${MACHINE_ABI:Mlittle-endian} && ${MACHINE_ABI:Mlong64}

emaste updated this revision to Diff 123734.Jun 25 2023, 12:26 AM

use @jrtc27's suggestion

emaste added a reviewer: jrtc27.Jun 25 2023, 12:27 AM
jrtc27 accepted this revision.Jun 25 2023, 10:01 AM
This revision is now accepted and ready to land.Jun 25 2023, 10:01 AM
Closed by commit rG9cbc371c8af7: libcrypto: build nistp* on all little-endian 64-bit targets (authored by emaste). · Explain WhyJun 25 2023, 1:37 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG9cbc371c8af7: libcrypto: build nistp* on all little-endian 64-bit targets.
Herald added a subscriber: imp. · View Herald TranscriptJun 25 2023, 1:37 PM

Revision Contents
Changeset List

PathSize
secure/
lib/
libcrypto/
6 lines

Diff 123734

View Options

secure/lib/libcrypto/Makefile

Loading...