libcrypto: build nistp* on powerpc64le and riscv64
ClosedPublic
Actions

Authored by emaste on Jun 24 2023, 5:57 PM.

Details

Reviewers

ngie
khorben_defora.org
jrtc27

Commits

rG9cbc371c8af7: libcrypto: build nistp* on all little-endian 64-bit targets

Summary

libcrypto intends to provide these routines on little-endian 64-bit targets.

Reported by:    ci.freebsd.org
Sponsored by:   The FreeBSD Foundation

Test Plan

make tinderbox in progress

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 24 2023, 5:57 PM

emaste created this revision.

emaste added inline comments.

secure/lib/libcrypto/Makefile
234	I'm not sure if `ASM_riscv64` gets defined or not

Define ASM_riscv64

emaste added a subscriber: lwhsu.Jun 24 2023, 6:04 PM

emaste added inline comments.Jun 24 2023, 6:41 PM

secure/lib/libcrypto/Makefile
234	Of course `ASM_*` isn't really right variable name for something controlling C files, but it's consistent with what's already here, and we may have riscv64 asm files in the future.

These should really be gated by ${MACHINE_ABI:Mlittle-endian} && ${MACHINE_ABI:Mlong64}

use @jrtc27's suggestion

emaste added a reviewer: jrtc27.Jun 25 2023, 12:27 AM

jrtc27 accepted this revision.Jun 25 2023, 10:01 AM

This revision is now accepted and ready to land.Jun 25 2023, 10:01 AM

Closed by commit rG9cbc371c8af7: libcrypto: build nistp* on all little-endian 64-bit targets (authored by emaste). · Explain WhyJun 25 2023, 1:37 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG9cbc371c8af7: libcrypto: build nistp* on all little-endian 64-bit targets.

Herald added a subscriber: imp. · View Herald TranscriptJun 25 2023, 1:37 PM

Revision Contents
Changeset List

Path

Size

secure/

lib/

libcrypto/

Makefile

6 lines

Diff 123734

View Options

secure/lib/libcrypto/Makefile

libcrypto: build nistp* on powerpc64le and riscv64ClosedPublicActions