Page MenuHomeFreeBSD
Differential D40729

lib/libc/tests/string: add unit tests for ffs, ffsl, ffsll, fls, flsl, and flsll
ClosedPublic
Actions

Authored by fuz on Jun 23 2023, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 7:25 AM
Unknown Object (File)
Sun, May 17, 10:50 AM
Unknown Object (File)
Sat, May 16, 9:09 PM
Unknown Object (File)
Fri, May 15, 5:13 PM
Unknown Object (File)
Fri, May 15, 2:16 PM
Unknown Object (File)
Fri, May 15, 7:40 AM
Unknown Object (File)
Thu, May 14, 8:51 PM
Unknown Object (File)
Thu, May 14, 10:31 AM
View All Files
Subscribers
imp
jrm
kevans

Details

Reviewers
mjg
kevans
ngie
Commits
rG65b618794f68: lib/libc/tests/string: add unit tests for ffs, ffsl, ffsll, fls, flsl, and flsll
rG49390697b926: lib/libc/tests/string: add unit tests for ffs, ffsl, ffsll, fls, flsl, and flsll
Summary

Add atf unit tests for ffs, ffsl, ffsll, fls, flsl, flsll.
These unit tests will be used for an upcoming DR.

Also supply CFLAGS+=-fno-builtin to ensure our unit tests
actually test libc functions and not clang's builtins.

Sponsored by: FreeBSD Foundation

Test Plan

Unit tests pass with current implementations of
these functions. This DR is the test plan for an upcoming DR.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52263
Build 49154: arc lint + arc unit

Event Timeline

fuz created this revision.Jun 23 2023, 9:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 23 2023, 9:45 PM
fuz requested review of this revision.Jun 23 2023, 9:45 PM
Harbormaster completed remote builds in B52263: Diff 123693.Jun 23 2023, 9:45 PM
fuz mentioned this in D40730: lib/libc/string: replace ffs/fls implementations with clang builtins.Jun 23 2023, 9:47 PM
kevans accepted this revision.Jun 28 2023, 7:47 PM
kevans added a reviewer: ngie.
kevans added a subscriber: kevans.

This seems to LGTM, let's perhaps pull in ngie for another sanity check. I think templating ffs_test and fls_test like this is a fine approach.

This revision is now accepted and ready to land.Jun 28 2023, 7:47 PM
ngie added a comment.Jun 28 2023, 8:08 PM

Are these testcases already implemented in the libm tests?

ngie added inline comments.Jun 28 2023, 8:41 PM
lib/libc/tests/string/flsll_test.c
28–30

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

fuz added a comment.Jun 28 2023, 10:14 PM

This seems to LGTM, let's perhaps pull in ngie for another sanity check. I think templating ffs_test and fls_test like this is a fine approach.

Thanks. Do I have approval to commit once @ngie approves? If yes, can this be MFC'ed to 13-STABLE?

Are these testcases already implemented in the libm tests?

I am not aware of any such tests.

lib/libc/tests/string/flsll_test.c
28–30

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

mjg added a comment.Jul 2 2023, 10:39 PM

I don't think these should run by default, in fact the overall suite is already taking way too long

can this be made condiitonal, even if installed

Closed by commit rG49390697b926: lib/libc/tests/string: add unit tests for ffs, ffsl, ffsll, fls, flsl, and flsll (authored by fuz). · Explain WhyJul 3 2023, 8:24 PM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: rG49390697b926: lib/libc/tests/string: add unit tests for ffs, ffsl, ffsll, fls, flsl, and flsll.
fuz added a commit: rG65b618794f68: lib/libc/tests/string: add unit tests for ffs, ffsl, ffsll, fls, flsl, and flsll.Jul 21 2023, 8:57 AM
fuz mentioned this in D41855: lib/libc/amd64: back out amd64 SIMD work.Sep 14 2023, 5:56 AM
fuz mentioned this in rG6dff5fb10b5e: lib/libc/amd64: back out amd64 SIMD work.Sep 19 2023, 3:20 AM

Revision Contents
Changeset List

PathSize
lib/
libc/
tests/
string/
9 lines
88 lines
32 lines
32 lines
88 lines
32 lines
32 lines

Diff 123693

View Options

lib/libc/tests/string/Makefile

Loading...
View Options

lib/libc/tests/string/ffs_test.c

Loading...
View Options

lib/libc/tests/string/ffsl_test.c

Loading...
View Options

lib/libc/tests/string/ffsll_test.c

Loading...
View Options

lib/libc/tests/string/fls_test.c

Loading...
View Options

lib/libc/tests/string/flsl_test.c

Loading...
View Options

lib/libc/tests/string/flsll_test.c

Loading...