Paths

Table of Contentst

Differential D40460

bhyve: add execution command for tpm devices
ClosedPublic
Actions

Authored by corvink on Jun 7 2023, 12:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 29, 10:32 PM

	Unknown Object (File)
	Wed, Sep 24, 7:14 PM

	Unknown Object (File)
	Tue, Sep 23, 11:12 PM

	Unknown Object (File)
	Mon, Sep 22, 2:32 PM

	Unknown Object (File)
	Mon, Sep 22, 12:15 PM

	Unknown Object (File)
	Mon, Sep 22, 12:06 PM

	Unknown Object (File)
	Mon, Sep 22, 9:57 AM

	Unknown Object (File)
	Mon, Sep 22, 6:06 AM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

Commits

rG29200a8133c0: bhyve: emulate TPM passthru by accessing /dev/tpmX

Summary

Executing a tpm command is as easy as writing the command to the tpm fd and reading back the result.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52259
Build 49150: arc lint + arc unit

Event Timeline

corvink created this revision.Jun 7 2023, 12:07 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJun 7 2023, 12:07 PM

corvink requested review of this revision.Jun 7 2023, 12:07 PM

Harbormaster completed remote builds in B51952: Diff 122927.Jun 7 2023, 12:07 PM

corvink added a child revision: D40461: bhyve: trap crb register of tpm devices.Jun 7 2023, 12:09 PM

corvink added a parent revision: D40459: bhyve/tpm: add emulation for crb register.

markj added inline comments.Jun 8 2023, 3:41 PM

usr.sbin/bhyve/tpm_emul_passthru.c
71	Should you check `rsp_size >= sizeof(struct tpm_resp_hdr)` before doing anything?
74	`rsp_size` is unsigned, the last format should be `%u`. I'm surprised the compiler doesn't warn about it.

address markj's feedback

Harbormaster completed remote builds in B52259: Diff 123673.Jun 23 2023, 9:34 AM

corvink marked 2 inline comments as done.Jun 23 2023, 9:37 AM

markj accepted this revision as: markj.Jun 23 2023, 2:58 PM

markj added inline comments.

usr.sbin/bhyve/tpm_emul_passthru.c
71
78

This revision is now accepted and ready to land.Jun 23 2023, 2:58 PM

corvink added a child revision: D40462: bhyve: add qemu ppi emulation for tpm devices.Aug 10 2023, 7:24 AM

Closed by commit rG29200a8133c0: bhyve: emulate TPM passthru by accessing /dev/tpmX (authored by corvink). · Explain WhyAug 10 2023, 7:41 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG29200a8133c0: bhyve: emulate TPM passthru by accessing /dev/tpmX.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

tpm_emul_passthru.c

38 lines

Diff 123673

usr.sbin/bhyve/tpm_emul_passthru.c

Loading...