Differential D40457

bhyve/tpm: build TPM2 table by tpm interface
ClosedPublic
Actions

Authored by corvink on Jun 7 2023, 12:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 14, 11:11 AM

	Unknown Object (File)
	Mon, Apr 14, 5:04 AM

	Unknown Object (File)
	Mon, Apr 14, 1:32 AM

	Unknown Object (File)
	Mon, Apr 14, 1:23 AM

	Unknown Object (File)
	Sun, Apr 13, 9:09 PM

	Unknown Object (File)
	Sun, Apr 13, 8:25 PM

	Unknown Object (File)
	Mar 15 2025, 12:33 PM

	Unknown Object (File)
	Mar 14 2025, 6:35 AM

View All 77 Files

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

Commits

rG5ea98d326830: bhyve/tpm: build TPM2 table by tpm interface

Summary

Each tpm has a device specific table. Which table a tpm uses depends on
the tpm interface.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Jun 7 2023, 12:05 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJun 7 2023, 12:05 PM

corvink requested review of this revision.Jun 7 2023, 12:05 PM

Harbormaster completed remote builds in B51949: Diff 122924.Jun 7 2023, 12:05 PM

corvink added a child revision: D40458: bhyve/tpm: create crb thread for sending tpm commands.Jun 7 2023, 12:09 PM

corvink added a parent revision: D40456: bhyve/tpm: add basic crb interface.

markj added inline comments.Jun 8 2023, 3:19 PM

usr.sbin/bhyve/tpm_intf_crb.c
246	Variable declarations should be followed by a newline.
274	IMO it would be better to introduce new basl routines to modify tables, rather than exporting tersely named global variables like this.

make use of new basl helper

Harbormaster completed remote builds in B52077: Diff 123268.Jun 15 2023, 9:44 AM

corvink edited parent revisions, added: D40559: bhyve: maintain RSDT and XSDT by basl; removed: D40456: bhyve/tpm: add basic crb interface.Jun 15 2023, 9:44 AM

corvink marked 2 inline comments as done.Jun 15 2023, 9:47 AM

corvink added inline comments.

usr.sbin/bhyve/tpm_intf_crb.c
274	D40559

markj accepted this revision as: markj.Jun 15 2023, 3:21 PM

markj added inline comments.

usr.sbin/bhyve/tpm_intf_crb.c
215
274	Nice, thank you.

This revision is now accepted and ready to land.Jun 15 2023, 3:21 PM

Closed by commit rG5ea98d326830: bhyve/tpm: build TPM2 table by tpm interface (authored by corvink). · Explain WhyJun 20 2023, 9:01 AM

This revision was automatically updated to reflect the committed changes.

corvink marked an inline comment as done.

corvink added a commit: rG5ea98d326830: bhyve/tpm: build TPM2 table by tpm interface.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

13 lines

4 lines

51 lines

Diff 123478

usr.sbin/bhyve/tpm_device.c

Loading...

usr.sbin/bhyve/tpm_intf.h

Loading...

usr.sbin/bhyve/tpm_intf_crb.c

Loading...