Page MenuHomeFreeBSD
Differential D40523

camcontrol: No need to set CAM_ARG_[PG]LIST in defects
ClosedPublic
Actions

Authored by imp on Jun 13 2023, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 10:55 PM
Unknown Object (File)
Fri, Sep 11, 2:41 AM
Unknown Object (File)
Tue, Sep 8, 10:31 PM
Unknown Object (File)
Sat, Sep 5, 5:45 PM
Unknown Object (File)
Sat, Sep 5, 3:57 AM
Unknown Object (File)
Fri, Sep 4, 8:11 PM
Unknown Object (File)
Fri, Sep 4, 1:09 PM
Unknown Object (File)
Thu, Sep 3, 12:05 PM
View All Files
Subscribers
None

Details

Reviewers
ken
mav
Commits
rGf20d86e17143: camcontrol: No need to set CAM_ARG_[PG]LIST in defects
Summary

We can or in the the list_format bits directly if we or in the
list_format when we look it up the first time. Free up CAM_ARG_[PG]LIST
from the CAM_ARG_xxx enum.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52146
Build 49037: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jun 13 2023, 9:26 PM
imp created this revision.
Harbormaster completed remote builds in B52032: Diff 123176.Jun 13 2023, 9:26 PM
imp added a parent revision: D40522: camcontrol: Simplfiy 12-byte retry logic in defects command.Jun 13 2023, 9:26 PM
imp added a child revision: D40524: camcontrol: simplify summary logic for defects.
imp added reviewers: ken, mav.Jun 13 2023, 9:28 PM
mav added inline comments.Jun 15 2023, 2:11 PM
sbin/camcontrol/camcontrol.c
3864

I suppose this will give unexpected result if -f specified twice.

imp added inline comments.Jun 15 2023, 3:29 PM
sbin/camcontrol/camcontrol.c
3864

So do I do last one wins like before, or a if (list_type_set) errx()?

mav added inline comments.Jun 15 2023, 3:49 PM
sbin/camcontrol/camcontrol.c
3864

Either would be good to me.

imp updated this revision to Diff 123447.Jun 19 2023, 8:40 PM

update, per review

Harbormaster completed remote builds in B52146: Diff 123447.Jun 19 2023, 8:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2023, 8:48 PM
Closed by commit rGf20d86e17143: camcontrol: No need to set CAM_ARG_[PG]LIST in defects (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGf20d86e17143: camcontrol: No need to set CAM_ARG_[PG]LIST in defects.

Revision Contents
Changeset List

PathSize
sbin/
camcontrol/
28 lines

Diff 123447

View Options

sbin/camcontrol/camcontrol.c

Loading...