Differential D40527

cam: Remove duplicate definition for READ_DEFECT_DATA_10
ClosedPublic
Actions

Authored by imp on Jun 13 2023, 9:26 PM.

Tags

None

Referenced Files

	F132170078: D40527.id.diff
	Tue, Oct 14, 10:14 AM

	F132170057: D40527.id123454.diff
	Tue, Oct 14, 10:14 AM

	F132170051: D40527.id123180.diff
	Tue, Oct 14, 10:14 AM

	Unknown Object (File)
	Mon, Oct 13, 8:04 PM

	Unknown Object (File)
	Mon, Sep 29, 11:23 AM

	Unknown Object (File)
	Mon, Sep 29, 9:28 AM

	Unknown Object (File)
	Sun, Sep 28, 8:17 AM

	Unknown Object (File)
	Sat, Sep 27, 9:50 PM

View All 68 Files

Subscribers

None

Details

Reviewers

ken
mav

Group Reviewers

Commits

rGa960d3c07bd3: cam: Remove duplicate definition for READ_DEFECT_DATA_10

Summary

This isn't needed by all devices and is only used by the da device (in
camcontrol). All the other da specific da scsi opcodes are only in
scsi_da.h.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jun 13 2023, 9:26 PM

Herald added a reviewer: cam. · View Herald TranscriptJun 13 2023, 9:26 PM

imp requested review of this revision.Jun 13 2023, 9:26 PM

Harbormaster completed remote builds in B52036: Diff 123180.Jun 13 2023, 9:26 PM

imp added a parent revision: D40526: camcontrol: In defects make -S actually imply 12-byte command.Jun 13 2023, 9:26 PM

imp added a child revision: D40528: camcontrol: Zone fix two warnings.

imp added reviewers: ken, mav.Jun 13 2023, 9:27 PM

The command is specified in SBC, not SPC, so it indeed make sense in scsi_da.h. From the same point I see also WRITE_SAME_10, UNMAP, and may be more, but at least those are not duplicate.

This revision is now accepted and ready to land.Jun 15 2023, 2:01 PM

In D40527#923402, @mav wrote:

The command is specified in SBC, not SPC, so it indeed make sense in scsi_da.h. From the same point I see also WRITE_SAME_10, UNMAP, and may be more, but at least those are not duplicate.

Ah! That's the touch stone for where things get defined....

Closed by commit rGa960d3c07bd3: cam: Remove duplicate definition for READ_DEFECT_DATA_10 (authored by imp). · Explain WhyJun 19 2023, 8:49 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa960d3c07bd3: cam: Remove duplicate definition for READ_DEFECT_DATA_10.

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

1 line

Diff 123454

sys/cam/scsi/scsi_all.h

Loading...