camcontrol: simplify summary logic for defects
ClosedPublic
Actions

Authored by imp on Jun 13 2023, 9:26 PM.

Details

Reviewers

ken
mav

Commits

rG2e105b61e98d: camcontrol: simplify summary logic for defects

Summary

We don't need to count the number of lists requested. Instead, use the
more general form of checking to see if any of the non-defect format
bits are set. Also, check summary boolean to control summary reporting
behavior.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 13 2023, 9:26 PM

imp created this revision.

Harbormaster completed remote builds in B52033: Diff 123177.Jun 13 2023, 9:26 PM

imp added a parent revision: D40523: camcontrol: No need to set CAM_ARG_[PG]LIST in defects.Jun 13 2023, 9:26 PM

imp added a child revision: D40525: camcontrol: Add support for -r XX to set reserved bits in defects.

imp added reviewers: ken, mav.Jun 13 2023, 9:28 PM

mav accepted this revision.Jun 15 2023, 2:07 PM

This revision is now accepted and ready to land.Jun 15 2023, 2:07 PM

Closed by commit rG2e105b61e98d: camcontrol: simplify summary logic for defects (authored by imp). · Explain WhyJun 19 2023, 8:49 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG2e105b61e98d: camcontrol: simplify summary logic for defects.

Revision Contents
Changeset List

Path

Size

sbin/

camcontrol/

camcontrol.c

8 lines

Diff 123452

View Options

sbin/camcontrol/camcontrol.c

camcontrol: simplify summary logic for defectsClosedPublicActions