Page MenuHomeFreeBSD

camcontrol: No need to set CAM_ARG_[PG]LIST in defects
ClosedPublic

Authored by imp on Jun 13 2023, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 10, 5:46 AM
Unknown Object (File)
Sun, Jun 9, 5:57 PM
Unknown Object (File)
Fri, May 17, 1:15 AM
Unknown Object (File)
May 2 2024, 10:10 AM
Unknown Object (File)
May 2 2024, 10:10 AM
Unknown Object (File)
May 2 2024, 10:10 AM
Unknown Object (File)
May 2 2024, 7:37 AM
Unknown Object (File)
May 2 2024, 12:45 AM
Subscribers
None

Details

Summary

We can or in the the list_format bits directly if we or in the
list_format when we look it up the first time. Free up CAM_ARG_[PG]LIST
from the CAM_ARG_xxx enum.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 13 2023, 9:26 PM
imp created this revision.
sbin/camcontrol/camcontrol.c
3864

I suppose this will give unexpected result if -f specified twice.

sbin/camcontrol/camcontrol.c
3864

So do I do last one wins like before, or a if (list_type_set) errx()?

sbin/camcontrol/camcontrol.c
3864

Either would be good to me.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2023, 8:48 PM
This revision was automatically updated to reflect the committed changes.