bhyve: use assert for missing TPM version
ClosedPublic
Actions

Authored by corvink on Jun 15 2023, 9:43 AM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rGb3564c233749: bhyve: use assert for missing TPM version

Summary

The TPM version config node should always be set. If it's not set,
there's a bug in our code. An assertion is the correct way to check for
this.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52074
Build 48965: arc lint + arc unit

Event Timeline

corvink created this revision.Jun 15 2023, 9:43 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJun 15 2023, 9:43 AM

corvink requested review of this revision.Jun 15 2023, 9:43 AM

Harbormaster completed remote builds in B52074: Diff 123265.Jun 15 2023, 9:43 AM

corvink added a child revision: D40454: bhyve: add basic TPM emulation struct.Jun 15 2023, 9:44 AM

corvink added a parent revision: D40453: bhyve: register TPM device as ACPI device.

corvink mentioned this in D40454: bhyve: add basic TPM emulation struct.Jun 15 2023, 9:47 AM

markj accepted this revision as: markj.Jun 15 2023, 3:09 PM

This revision is now accepted and ready to land.Jun 15 2023, 3:09 PM

Closed by commit rGb3564c233749: bhyve: use assert for missing TPM version (authored by corvink). · Explain WhyJun 16 2023, 6:23 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGb3564c233749: bhyve: use assert for missing TPM version.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

tpm_device.c

4 lines

Diff 123265

View Options

usr.sbin/bhyve/tpm_device.c

bhyve: use assert for missing TPM versionClosedPublicActions