Page MenuHomeFreeBSD
Differential D40521

camcontrol: Convert int used as booleans to bools in defects command
ClosedPublic
Actions

Authored by imp on Jun 13 2023, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 7:16 AM
Unknown Object (File)
Mon, Mar 10, 12:10 PM
Unknown Object (File)
Thu, Mar 6, 2:59 AM
Unknown Object (File)
Feb 11 2025, 5:25 PM
Unknown Object (File)
Jan 6 2025, 9:20 PM
Unknown Object (File)
Jan 6 2025, 1:10 PM
Unknown Object (File)
Jan 5 2025, 12:32 AM
Unknown Object (File)
Dec 5 2024, 10:29 PM
View All 51 Files
Subscribers
None

Details

Reviewers
ken
mav
Commits
rGfc78fd9dae66: camcontrol: Convert int used as booleans to bools
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52030
Build 48921: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
camcontrol/
78 lines

Diff 123174

View Options

sbin/camcontrol/camcontrol.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
#define _NET_VNET_H_ #define _NET_VNET_H_
/* /*
* struct vnet describes a virtualized network stack, and is primarily a * struct vnet describes a virtualized network stack, and is primarily a
* pointer to storage for virtualized global variables. Expose to userspace * pointer to storage for virtualized global variables. Expose to userspace
* as required for libkvm. * as required for libkvm.
*/ */
#if defined(_KERNEL) || defined(_WANT_VNET) #if defined(_KERNEL) || defined(_WANT_VNET)
#include <machine/param.h> /* for CACHE_LINE_SIZE */
glebiusUnsubmitted
Not Done
Inline Actions

Why is this change in here?

glebius: Why is this change in here?
karelsAuthorUnsubmitted
Done
Inline Actions

It was required to get in.c to compile with vnet.h. It could be in a separate commit, although it would not make vnet.h self-sufficient.

karels: It was required to get in.c to compile with vnet.h. It could be in a separate commit, although…
bzUnsubmitted
Not Done
Inline Actions

What was the error that cannot be fixed in the in.c code itself? It seems wrong here.

bz: What was the error that cannot be fixed in the in.c code itself? It seems wrong here.
karelsAuthorUnsubmitted
Done
Inline Actions

Correction: in.c compiles without this include, but other users of in.h fail if it includes vnet.h, such as nlm/sm_inter_xdr.c.

karels: Correction: in.c compiles without this include, but other users of in.h fail if it includes…
bzUnsubmitted
Not Done
Inline Actions

Well, that file clearly violates FreeBSD expectations (being generated or not). The problem needs to be fixed there.

style.9:

Kernel include files (sys/*.h) come first.  If <sys/cdefs.h> is needed
for __FBSDID(), include it first.  If either <sys/types.h> or
<sys/param.h> is needed, include it before other include files.
(<sys/param.h> includes <sys/types.h>; do not include both.) Next,
include <sys/systm.h>, if needed.  The remaining kernel headers should be
sorted alphabetically.

and nlm/sm_inter_xdr.c.

#include <nlm/sm_inter.h>
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");

and them all the way down to sys/rpc/rpc.h and from there to netinet/in.h L423. Sad this is all so IPv4-only stuff still .. but that's a different problem.

bz: Well, that file clearly violates FreeBSD expectations (being generated or not). The problem…
#include <sys/queue.h> #include <sys/queue.h>
struct vnet { struct vnet {
LIST_ENTRY(vnet) vnet_le; /* all vnets list */ LIST_ENTRY(vnet) vnet_le; /* all vnets list */
u_int vnet_magic_n; u_int vnet_magic_n;
u_int vnet_ifcnt; u_int vnet_ifcnt;
u_int vnet_sockcnt; u_int vnet_sockcnt;
u_int vnet_state; /* SI_SUB_* */ u_int vnet_state; /* SI_SUB_* */
▲ Show 20 Lines • Show All 387 Lines • Show Last 20 Lines