Page MenuHomeFreeBSD

hwpmc: split out PMC_OP_PMCRELEASE
ClosedPublic

Authored by mhorne on May 26 2023, 6:40 PM.
Tags
None
Referenced Files
F126517397: D40293.id122722.diff
Wed, Aug 20, 11:43 AM
Unknown Object (File)
Fri, Aug 15, 12:19 PM
Unknown Object (File)
Thu, Aug 14, 10:41 PM
Unknown Object (File)
Thu, Aug 14, 10:32 PM
Unknown Object (File)
Mon, Aug 4, 11:51 AM
Unknown Object (File)
Jul 20 2025, 3:16 AM
Unknown Object (File)
Jul 20 2025, 2:06 AM
Unknown Object (File)
Jul 20 2025, 1:11 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51842
Build 48733: arc lint + arc unit

Event Timeline

jkoshy requested changes to this revision.May 31 2023, 6:55 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3581

How about returning early in case of an error? Doing so would be consistent with the way errors
are handled in other parts of the code.

error = pmc_find_pmc(...)
if (error != 0)
   return (error);
This revision now requires changes to proceed.May 31 2023, 6:55 AM

Adjust error handling to return directly.

mhorne added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3581

Sure thing. Not sure why I structured this one this way...

This revision is now accepted and ready to land.Jun 2 2023, 8:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.