Page MenuHomeFreeBSD
Differential D40293

hwpmc: split out PMC_OP_PMCRELEASE
ClosedPublic
Actions

Authored by mhorne on May 26 2023, 6:40 PM.
Tags
None
Referenced Files
F114891395: D40293.id122495.diff
Fri, Apr 18, 5:08 AM
Unknown Object (File)
Sat, Apr 12, 7:12 AM
Unknown Object (File)
Tue, Mar 25, 7:29 PM
Unknown Object (File)
Mar 6 2025, 8:07 AM
Unknown Object (File)
Feb 9 2025, 7:41 PM
Unknown Object (File)
Jan 27 2025, 11:12 AM
Unknown Object (File)
Jan 26 2025, 6:46 PM
Unknown Object (File)
Jan 23 2025, 3:53 PM
View All 77 Files
Subscribers
imp

Details

Reviewers
jkoshy
emaste
gnn
Group Reviewers
pmc
Commits
rGf4fac946c6a5: hwpmc: split out PMC_OP_PMCRELEASE

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51842
Build 48733: arc lint + arc unit

Event Timeline

mhorne created this revision.May 26 2023, 6:40 PM
Herald added a reviewer: gnn. · View Herald TranscriptMay 26 2023, 6:40 PM
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.May 26 2023, 6:40 PM
Harbormaster completed remote builds in B51721: Diff 122495.May 26 2023, 6:40 PM
mhorne added a parent revision: D40292: hwpmc: split out PMC_OP_PMCALLOCATE.May 26 2023, 6:40 PM
mhorne added a child revision: D40294: hwpmc: split out PMC_OP_PMCRW.
jkoshy requested changes to this revision.May 31 2023, 6:55 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3581

How about returning early in case of an error? Doing so would be consistent with the way errors
are handled in other parts of the code.

error = pmc_find_pmc(...)
if (error != 0)
   return (error);
This revision now requires changes to proceed.May 31 2023, 6:55 AM
mhorne updated this revision to Diff 122722.Jun 1 2023, 6:18 PM

Adjust error handling to return directly.

Harbormaster completed remote builds in B51842: Diff 122722.Jun 1 2023, 6:18 PM
mhorne marked an inline comment as done.Jun 1 2023, 6:18 PM
mhorne added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3581

Sure thing. Not sure why I structured this one this way...

jkoshy accepted this revision.Jun 2 2023, 8:47 PM
This revision is now accepted and ready to land.Jun 2 2023, 8:47 PM
Closed by commit rGf4fac946c6a5: hwpmc: split out PMC_OP_PMCRELEASE (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.
mhorne added a commit: rGf4fac946c6a5: hwpmc: split out PMC_OP_PMCRELEASE.

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
66 lines

Diff 122722

View Options

sys/dev/hwpmc/hwpmc_mod.c

Show First 20 Lines • Show All 185 Lines • ▼ Show 20 Lines while (len != 0) {
if (__predict_false(pi->rm_size & (RNDIS_PKTINFO_ALIGN - 1))) if (__predict_false(pi->rm_size & (RNDIS_PKTINFO_ALIGN - 1)))
return (EINVAL); return (EINVAL);
if (__predict_false(pi->rm_size < pi->rm_pktinfooffset)) if (__predict_false(pi->rm_size < pi->rm_pktinfooffset))
return (EINVAL); return (EINVAL);
dlen = pi->rm_size - pi->rm_pktinfooffset; dlen = pi->rm_size - pi->rm_pktinfooffset;
data = pi->rm_data; data = pi->rm_data;
switch (pi->rm_type) { switch (pi->rm_type) {
case ieee_8021q_info: case NDIS_PKTINFO_TYPE_VLAN:
if (__predict_false(dlen < NDIS_VLAN_INFO_SIZE)) if (__predict_false(dlen < NDIS_VLAN_INFO_SIZE))
return (EINVAL); return (EINVAL);
info->vlan_info = *((const uint32_t *)data); info->vlan_info = *((const uint32_t *)data);
mask |= HV_RF_RECVINFO_VLAN; mask |= HV_RF_RECVINFO_VLAN;
break; break;
case tcpip_chksum_info: case NDIS_PKTINFO_TYPE_CSUM:
if (__predict_false(dlen < NDIS_RXCSUM_INFO_SIZE)) if (__predict_false(dlen < NDIS_RXCSUM_INFO_SIZE))
return (EINVAL); return (EINVAL);
info->csum_info = *((const uint32_t *)data); info->csum_info = *((const uint32_t *)data);
mask |= HV_RF_RECVINFO_CSUM; mask |= HV_RF_RECVINFO_CSUM;
break; break;
case nbl_hash_value: case HN_NDIS_PKTINFO_TYPE_HASHVAL:
if (__predict_false(dlen < HN_NDIS_HASH_VALUE_SIZE)) if (__predict_false(dlen < HN_NDIS_HASH_VALUE_SIZE))
return (EINVAL); return (EINVAL);
info->hash_value = *((const uint32_t *)data); info->hash_value = *((const uint32_t *)data);
mask |= HV_RF_RECVINFO_HASHVAL; mask |= HV_RF_RECVINFO_HASHVAL;
break; break;
case nbl_hash_info: case HN_NDIS_PKTINFO_TYPE_HASHINF:
if (__predict_false(dlen < HN_NDIS_HASH_INFO_SIZE)) if (__predict_false(dlen < HN_NDIS_HASH_INFO_SIZE))
return (EINVAL); return (EINVAL);
info->hash_info = *((const uint32_t *)data); info->hash_info = *((const uint32_t *)data);
mask |= HV_RF_RECVINFO_HASHINF; mask |= HV_RF_RECVINFO_HASHINF;
break; break;
default: default:
goto next; goto next;
▲ Show 20 Lines • Show All 822 Lines • Show Last 20 Lines