Page MenuHomeFreeBSD

hwpmc: split out PMC_OP_PMCRELEASE
ClosedPublic

Authored by mhorne on May 26 2023, 6:40 PM.
Tags
None
Referenced Files
F143799274: D40293.diff
Sat, Jan 31, 2:16 PM
Unknown Object (File)
Wed, Jan 28, 5:00 PM
Unknown Object (File)
Sat, Jan 17, 5:19 AM
Unknown Object (File)
Dec 13 2025, 1:00 AM
Unknown Object (File)
Nov 27 2025, 9:28 PM
Unknown Object (File)
Nov 25 2025, 12:07 PM
Unknown Object (File)
Nov 20 2025, 11:03 PM
Unknown Object (File)
Nov 20 2025, 12:48 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51721
Build 48612: arc lint + arc unit

Event Timeline

jkoshy requested changes to this revision.May 31 2023, 6:55 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3647

How about returning early in case of an error? Doing so would be consistent with the way errors
are handled in other parts of the code.

error = pmc_find_pmc(...)
if (error != 0)
   return (error);
This revision now requires changes to proceed.May 31 2023, 6:55 AM

Adjust error handling to return directly.

mhorne added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3647

Sure thing. Not sure why I structured this one this way...

This revision is now accepted and ready to land.Jun 2 2023, 8:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.