Details
- Reviewers
grahamperrin arrowd tcberner adamw - Group Reviewers
vbox - Commits
- R11:8b9f42573ed3: emulators/virtualbox-ose[-legacy]: VM VirtualBox Manager: Help menu: unable to…
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh | ||
---|---|---|
19 | I'm not sure that putting /usr/local/ before base is good practice. With this patch, a malicious /usr/local/bin/mount could be called instead of /sbin/mount. Would we be better off putting /usr/local/... at the end instead? |
emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh | ||
---|---|---|
19 | My 1st version before upload here was: |
emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh | ||
---|---|---|
19 | I always start with what FreeBSD itself uses (from /etc/login.conf, and I skip ~/bin of course): $ awk '/path/ {print;exit;}' /etc/login.conf :path=/sbin /bin /usr/sbin /usr/bin /usr/local/sbin /usr/local/bin ~/bin:\ At the end of the day, you're the committer. Don't be afraid to modify patches from submitters; they're counting on you for that. Most submitters see changes in the final patch as a learning opportunity. |
Ideally, we'd want to use %%LOCALBASE%% substitution there, but meh. I think this is fine as it is.
Replaced all "/usr/local" with %%LOCALBASE%% and "/usr/local/lib/virtualbox" with %%VBOX_DIR%%.
emulators/virtualbox-ose-legacy/Makefile | ||
---|---|---|
327 ↗ | (On Diff #122066) | %%LOCALBASE%% should be replaced with ${LOCALBASE}, obviously. |
emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh | ||
20 | Here %%PREFIX should be used, I believe. | |
emulators/virtualbox-ose/files/patch-src_VBox_HostDrivers_adpctl_VBoxNetAdpCtl.cpp | ||
8 ↗ | (On Diff #122066) | %%PREFIX%% |
Removed double REINPLACE_CMD for src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp - 1st is in patch.