emulators/virtualbox-ose[-legacy]: VM VirtualBox Manager: Help menu: unable to open external browser

[vvd]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266778

[adamw]

emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh

19

I'm not sure that putting /usr/local/ before base is good practice. With this patch, a malicious /usr/local/bin/mount could be called instead of /sbin/mount. Would we be better off putting /usr/local/... at the end instead?

[vvd]

emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh

19

My 1st version before upload here was:
/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/local/sbin
But changed to current after read patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=237357&action=diff

[adamw]

emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh

19

I always start with what FreeBSD itself uses (from /etc/login.conf, and I skip ~/bin of course):

$ awk '/path/ {print;exit;}' /etc/login.conf
        :path=/sbin /bin /usr/sbin /usr/bin /usr/local/sbin /usr/local/bin ~/bin:\

At the end of the day, you're the committer. Don't be afraid to modify patches from submitters; they're counting on you for that. Most submitters see changes in the final patch as a learning opportunity.

[vvd]

PATH changed to: /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin

[arrowd]

Ideally, we'd want to use %%LOCALBASE%% substitution there, but meh. I think this is fine as it is.

[adamw]

In D40119#914019, @arrowd wrote:

Ideally, we'd want to use %%LOCALBASE%% substitution there, but meh. I think this is fine as it is.

We do, actually. https://github.com/freebsd/freebsd-ports/blob/main/emulators/virtualbox-ose-legacy/Makefile#L326

[vvd]

Replaced all "/usr/local" with %%LOCALBASE%% and "/usr/local/lib/virtualbox" with %%VBOX_DIR%%.

[arrowd]

emulators/virtualbox-ose-legacy/Makefile

327

%%LOCALBASE%% should be replaced with ${LOCALBASE}, obviously.

emulators/virtualbox-ose-legacy/files/patch-src-VBox-Installer-freebsd-VBox.sh

20

Here %%PREFIX should be used, I believe.

emulators/virtualbox-ose/files/patch-src_VBox_HostDrivers_adpctl_VBoxNetAdpCtl.cpp

8

%%PREFIX%%

[vvd]

After discussion in IRC did several improvements.

[vvd]

Removed double REINPLACE_CMD for src/VBox/HostDrivers/adpctl/VBoxNetAdpCtl.cpp - 1st is in patch.

[arrowd]

Great job!