Remove unused fields in siftr_stats. Thus, update the man page as well.
ClosedPublic
Actions

Authored by cc on Apr 24 2023, 11:48 AM.

Details

Reviewers

rscheff
tuexen

Commits

Summary

Remove unused fields in siftr_stats. Thus, update the man page as well.

Test Plan

Tested in Emulab testbed.

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 51158
Build 48049: arc lint + arc unit

cc requested review of this revision.Apr 24 2023, 11:48 AM

share/man/man4/siftr.4
32	You need to bump the date.
sys/netinet/siftr.c
114–115	Don't you need to bump `V_BACKBREAK`, since you are changing the output format in a non-compatible way (removing two entries)?

cc added inline comments.Apr 24 2023, 1:23 PM

share/man/man4/siftr.4
32	Will do.
sys/netinet/siftr.c
114–115	I thought the recent changes such as t_flags2, flowid, and flowtype made this requirement insignificant. Just want to double confirm that is this version bump really necessary?

sys/netinet/siftr.c
114–115	I don't know. But I would expect the siftr version number to reflect changes in the siftr code. Since you are removing two fields from the trailer, I would assume it applies. Changes of the TCP code would be reflected in the OS version, I would guess.