Page MenuHomeFreeBSD
Differential D39746

Delete unreachable code
ClosedPublic
Actions

Authored by zlei on Apr 21 2023, 10:03 AM.
Tags
None
Referenced Files
F131579607: D39746.id120884.diff
Thu, Oct 9, 11:16 AM
F131571191: D39746.diff
Thu, Oct 9, 9:14 AM
F131569461: D39746.id120806.diff
Thu, Oct 9, 8:50 AM
F131569302: D39746.diff
Thu, Oct 9, 8:48 AM
F131569293: D39746.id120797.diff
Thu, Oct 9, 8:48 AM
Unknown Object (File)
Fri, Oct 3, 12:56 AM
Unknown Object (File)
Fri, Oct 3, 12:27 AM
Unknown Object (File)
Sun, Sep 21, 12:42 AM
View All 74 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
ae
kp
Group Reviewers
network
Commits
rG2a3147f96241: ip_mroute: Delete unreachable code
rG1ff44a05d6bc: if_stf: Delete unreachable code
rGece63e96c364: ip_mroute: Delete unreachable code
rGf70caf1b4524: if_stf: Delete unreachable code
rGb658c0fce10a: ip_mroute: Delete unreachable code
rGc373e1d6adbc: if_stf: Delete unreachable code
Summary

As the flag M_WAITOK is passed to ip_encap_attach(), then the function will never return NULL, and the following code within NULL check branch will be unreachable.

No functional change intended.

Fixes: 6d8fdfa9d5e7d Rework IP encapsulation handling code
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Apr 21 2023, 10:03 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptApr 21 2023, 10:03 AM
zlei requested review of this revision.Apr 21 2023, 10:03 AM
zlei edited the summary of this revision. (Show Details)
zlei updated this revision to Diff 120806.Apr 21 2023, 10:22 AM
zlei retitled this revision from if_stf: Delete unreachable code to Delete unreachable code.

I'd like to commit them separately.

kp accepted this revision as: kp.Apr 21 2023, 11:11 AM
This revision is now accepted and ready to land.Apr 21 2023, 11:11 AM
zlei edited the summary of this revision. (Show Details)Apr 23 2023, 1:25 AM
Closed by commit rGc373e1d6adbc: if_stf: Delete unreachable code (authored by zlei). · Explain WhyApr 23 2023, 4:49 AM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rGc373e1d6adbc: if_stf: Delete unreachable code.
zlei added a commit: rGb658c0fce10a: ip_mroute: Delete unreachable code.
zlei added a commit: rGf70caf1b4524: if_stf: Delete unreachable code.May 17 2023, 9:59 AM
zlei added a commit: rGece63e96c364: ip_mroute: Delete unreachable code.
zlei added a commit: rG1ff44a05d6bc: if_stf: Delete unreachable code.May 17 2023, 10:05 AM
zlei added a commit: rG2a3147f96241: ip_mroute: Delete unreachable code.

Revision Contents
Changeset List

PathSize
sys/
net/
6 lines

Diff 120797

View Options

sys/net/if_stf.c

Loading...