libsa: Update comments about SMBIOS specification
ClosedPublic
Actions

Authored by stevek on Apr 18 2023, 1:51 AM.

Details

Reviewers

jmg
manu
imp

Commits

rGb5c3ade7657a: libsa: Update comments about SMBIOS specification

Summary

Include details from the SMBIOS 3 specification and some additional
details for SMBIOS 2.1.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50982
Build 47873: arc lint + arc unit

Event Timeline

stevek created this revision.Apr 18 2023, 1:51 AM

Herald added a reviewer: manu. · View Herald TranscriptApr 18 2023, 1:51 AM

Herald added subscribers: dab, imp. · View Herald Transcript

stevek requested review of this revision.Apr 18 2023, 1:51 AM

Harbormaster completed remote builds in B50980: Diff 120526.Apr 18 2023, 1:51 AM

I generally like this a lot. Thanks for doing it.

stand/libsa/smbios.c
90	Needs a closing quote. Also, this is starting to get a little lengthy for a quote. Do the standards say you need permission to quote? If not, I think it's short enough to be fine. If it does, however, we may look to trim a bit.

imp accepted this revision.Apr 18 2023, 2:57 AM

This revision is now accepted and ready to land.Apr 18 2023, 2:57 AM

In D39635#902089, @imp wrote:

Also, this is starting to get a little lengthy for a quote. Do the standards say you need permission to quote? If not, I think it's short enough to be fine. If it does, however, we may look to trim a bit.

According to the specification:
"Members and non-members may reproduce DMTF specifications and documents, provided that correct attribution is given."

Added closing quote per review comments

This revision now requires review to proceed.Apr 18 2023, 3:08 AM

Harbormaster completed remote builds in B50982: Diff 120528.Apr 18 2023, 3:08 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 18 2023, 3:22 AM

Closed by commit rGb5c3ade7657a: libsa: Update comments about SMBIOS specification (authored by stevek). · Explain Why

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rGb5c3ade7657a: libsa: Update comments about SMBIOS specification.